Conversation
vishvananda
force-pushed
the
info
branch
4 times, most recently
from
d6d6d80 to
6b41068
Compare
This renames the `issuer` command to `info` and adds the app name and url to the data printed. Output now looks like: ``` name=local url=http://localhost:5000 iss=http://localhost:5000 sub=local ```
wycats
requested changes
Jan 16, 2025
Contributor
wycats
left a comment
wycats
left a comment
There was a problem hiding this comment.
I didn't get a chance to review it all in detail, but it looks generally good. My only substantive question is whether the output of info should be JSON (or at least support JSON output).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames the
issuercommand toinfoand adds the app name and url to the data printed. Output now looks like: