Conversation
Issuer did not properly support any provider other than local. This fixes the implementation by implementing get_iss for all providers. This also allows us to avoid having to create a token as the fallback for discovery.
wycats
approved these changes
Jan 10, 2025
| async fn get_sub(&self) -> Result<String>; | ||
| async fn get_token(&self, audience: &str) -> Result<String>; | ||
| async fn get_iss_and_jwks(&self) -> Result<Option<(String, String)>>; | ||
| async fn get_iss(&self) -> Result<String>; |
Contributor
There was a problem hiding this comment.
This seems like a good separation.
src/identity/mod.rs
Outdated
| env::set_var_file("ISSUER", &issuer, &self.issuer_path)?; | ||
| } | ||
| let issuer = self.provider.get_iss().await?; | ||
| let mut file = File::create(&self.issuer_path).await?; |
Member
Author
There was a problem hiding this comment.
only because i didn't know it existed :)
| // No jwks management | ||
| Ok(None) | ||
| async fn get_iss(&self) -> Result<String> { | ||
| self.config.issuer.clone().context("Issuer not configured") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issuer did not properly support any provider other than local.
This fixes the implementation by implementing get_iss for all providers. This also allows us to avoid having to create a token as the fallback for discovery.