Fixes #81: Supervision mode by zner0L · Pull Request #82 · tweaselORG/appstraction

zner0L · 2023-05-30T21:06:35Z

No description provided.

baltpeter

Enabling and removing supervision did work in my tests, but SSH doesn't come back afterwards (#81 (comment)).

src/index.ts

src/ios.ts

src/index.ts

baltpeter · 2023-06-20T16:57:18Z

With my iOS 15 on palera1n-c, SSH does now come back after the userspace restart but I am still getting an error in ensureDevice() if I enable the supervision capability:

node:events:491
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at __node_internal_errnoException (node:internal/errors:620:12)
    at TCP.onStreamRead (node:internal/stream_base_commons:217:20)
Emitted 'error' event on Client instance at:
    at Socket.<anonymous> (/home/benni/coding/JS/tweasel/appstraction/node_modules/ssh2/lib/client.js:745:12)
    at Socket.emit (node:events:513:28)
    at Socket.emit (node:domain:489:12)
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  errno: -104,
  code: 'ECONNRESET',
  syscall: 'read',
  level: 'client-socket'
}

Removing supervision doesn't throw an error, but that's only because it doesn't wait for the device to come back. If I wanted to run another command afterwards, it would fail.

baltpeter · 2023-06-20T17:03:44Z

Curiously, on the other iPhone with iOS 16 (still on palera1n-legacy), it just hangs after removing supervision, even after the process is already done. Afterwards, I need to do "" in the palera1n app to get SSH back.

Enabling supervision also hangs after the phone has "rebooted".

baltpeter · 2023-06-20T17:04:15Z

Also, I wouldn't consider this ready to merge unless the device is actually ready to be used again automatically (i.e. unlocked) after enabling or removing supervision.

zner0L · 2023-06-21T15:31:48Z

I have researched a bit into how to unlock devices automatically, and I would like to finish this, but I am unsure of how much time I should poor into this now. I could try to get it done in 5 hours and if that works out fine we merge and if not, we move on for now.

baltpeter · 2023-06-22T10:35:03Z

Five hours is a lot…

…ken devices

baltpeter · 2023-06-28T10:27:41Z

src/index.ts

        : never;
+
+    /** Simulates key presses to unlock the screen. This only works if no passcode is set on the device. */
+    unlockScreen: () => Promise<void>;


Screen unlocking seems like something worthy of inclusion in the README feature list.

baltpeter · 2023-06-28T10:35:35Z

src/ios.ts

+                python('pymobiledevice3', ['processes', 'ps', '--no-color']).then(({ stdout }) =>
+                    Object.values(JSON.parse(stdout) as Record<string, Record<string, string>>).some(
+                        (p) => p['ProcessName'] === 'assistivetouchd'
+                    )
+                ),


Why not use Frida's device.enumerateProcesses() since we need Frida here anyway?

baltpeter · 2023-06-28T10:37:08Z

src/ios.ts

+Object.getOwnPropertyNames(atServer)
+atServer._home()


Suggested change

Object.getOwnPropertyNames(atServer)

atServer._home()

Object.getOwnPropertyNames(atServer);

atServer._home();

baltpeter · 2023-06-28T10:52:35Z

src/ios.ts

+                    );
+                // TODO: Enable AssistiveTouch automatically. This can be done via lockdownd, but is not supported by pymobiledevice3, yet.
+            });
+        // Since assistivetouchd always crashes after the simulated home button press, we need to wait for it to restart.


I can't reproduce that crashing on either of my iPhones. But I guess if you want to keep the waiting, you should also wait after the second home button press. Otherwise, I would two unlockScreen() calls to fail¹ on your device.

Footnotes

With a prompt to enable Assistive Touch, which is wrong in that case. ↩

baltpeter · 2023-06-28T10:54:19Z

src/index.ts

               */
              setupEnvironment: () => Promise<void>;
              ensureFrida: () => Promise<void>;
+              /**


You should advertise enabling and disabling supervision without resetting on rooted devices in the feature list as well.

baltpeter · 2023-06-28T10:56:07Z

src/index.ts

+            ('supervision' extends Capability
+                ? {
+                      /**
+                       * The password of the private key of the supervision certificate, defaults to `appstraction` if
+                       * not set.
+                       */
+                      supervisionKeyPassword?: string;
+                  }
+                : unknown);


Didn't we say we wanted to disable the capability until it is actually needed for anything?

baltpeter · 2023-06-28T11:07:24Z

I'm still getting ECONNRESET in the supervision operations during the reboot:

node:internal/process/promises:288
            triggerUncaughtException(err, true /* fromPromise */);
            ^

Error: read ECONNRESET
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at __node_internal_errnoException (node:internal/errors:620:12)
    at TCP.onStreamRead (node:internal/stream_base_commons:217:20) {
  errno: -104,
  code: 'ECONNRESET',
  syscall: 'read',
  level: 'client-socket'
}

And I'm pretty sure you've already spent a lot more than 5 hours…

zner0L mentioned this pull request May 31, 2023

Fixes #79: Implement subject_hash_old without OpenSSL #80

Merged

zner0L force-pushed the z_supervision branch from 2a667c8 to c50562a Compare June 1, 2023 15:02

zner0L marked this pull request as ready for review June 1, 2023 15:02

zner0L requested a review from baltpeter June 1, 2023 15:03

baltpeter requested changes Jun 2, 2023

View reviewed changes

zner0L force-pushed the z_supervision branch from c223958 to 2475620 Compare June 5, 2023 14:29

zner0L requested a review from baltpeter June 16, 2023 20:38

zner0L added 8 commits June 26, 2023 21:36

Split up util.ts

074acee

Add utility functions to generate certificates

33f3288

Fixes #81: Implement a function to enable supervision mode on jailbro…

030f955

…ken devices

Fixes #83: Replace pkijs with forge

c532c72

Add supervision capability

dbbf2fb

Implement changes from testing on iOS 16

ca16939

Fixes #107: Simulate buttons to unlock the devices

c5b854c

Leave the device in a ready state after supervision

f9690df

zner0L force-pushed the z_supervision branch from 2475620 to f9690df Compare June 26, 2023 21:18

baltpeter requested changes Jun 28, 2023

View reviewed changes

Conversation

zner0L commented May 30, 2023

Uh oh!

baltpeter left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

baltpeter commented Jun 20, 2023

Uh oh!

baltpeter commented Jun 20, 2023

Uh oh!

baltpeter commented Jun 20, 2023

Uh oh!

zner0L commented Jun 21, 2023

Uh oh!

baltpeter commented Jun 22, 2023

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Footnotes

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

baltpeter Jun 28, 2023

Choose a reason for hiding this comment

Uh oh!

baltpeter commented Jun 28, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants