Add optional hie_bios output group to haskell_repl#1263
Merged
mergify[bot] merged 5 commits intomasterfrom Mar 5, 2020
Merged
Conversation
mboes
approved these changes
Mar 5, 2020
These flags were duplicated in the toolchain, doctest, and the repl wrapper. Now they are defined in a single location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows users to configure
hie-biosto use these outputs to determine GHC flags. See #1262 (WIP) for an example setup withghcide.ghciandhie-biosin thehaskell_replimplementation.cc_wrapperto avoid duplication.haskell_replthat produces a file holding all relevant ghci flags for that target. (Excludes flags that are ghci specific, e.g.repl_ghci_argsor flags required for-ghci-script)A downside of this approach, compared to e.g. hrepl, is that
haskell_repltargets are not generated on-the-fly but have to be defined inBUILDfiles. However, this is a general limitation ofhaskell_repl.