Skip to content

Add optional hie_bios output group to haskell_repl#1263

Merged
mergify[bot] merged 5 commits intomasterfrom
hie-bios
Mar 5, 2020
Merged

Add optional hie_bios output group to haskell_repl#1263
mergify[bot] merged 5 commits intomasterfrom
hie-bios

Conversation

@aherrmann
Copy link
Copy Markdown
Contributor

This allows users to configure hie-bios to use these outputs to determine GHC flags. See #1262 (WIP) for an example setup with ghcide.

  • Factors out the common flags for ghci and hie-bios in the haskell_repl implementation.
  • Factors out the GHC flags required to configure cc_wrapper to avoid duplication.
  • Creates an output group for haskell_repl that produces a file holding all relevant ghci flags for that target. (Excludes flags that are ghci specific, e.g. repl_ghci_args or flags required for -ghci-script)

A downside of this approach, compared to e.g. hrepl, is that haskell_repl targets are not generated on-the-fly but have to be defined in BUILD files. However, this is a general limitation of haskell_repl.

Copy link
Copy Markdown
Collaborator

@cocreature cocreature left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you!

Comment thread haskell/cc.bzl Outdated
@aherrmann aherrmann added the merge-queue merge on green CI label Mar 5, 2020
@mergify mergify bot merged commit dd4dc5d into master Mar 5, 2020
@mergify mergify bot deleted the hie-bios branch March 5, 2020 13:48
@mergify mergify bot removed the merge-queue merge on green CI label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants