Skip to content

Make play nice with https://github.com/guregu/null - #6

Open
fwwieffering wants to merge 8 commits into
tvi:masterfrom
fwwieffering:master
Open

Make play nice with https://github.com/guregu/null#6
fwwieffering wants to merge 8 commits into
tvi:masterfrom
fwwieffering:master

Conversation

@fwwieffering

Copy link
Copy Markdown

the Null* structs all contain a boolean field Valid. This was getting filled randomly, which resulted in these fields being null when marshaled to JSON / db queries.

Always set Valid: true for gopkg.in/guregu/null.v3.* packages

@tvi

tvi commented Feb 1, 2019

Copy link
Copy Markdown
Owner

Thank you for your PR. I will look at it over weekend

mirusck pushed a commit to mirusck/datafiller that referenced this pull request Jul 15, 2019
updated the go.sum which was still pulling in datafiller as a dependancy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants