Repository navigation
Remove grecaptcha_response max length - #561
Merged
Merged
Conversation
Google reCAPTCHA tokens now exceed 2048 chars, so every enquiry POST was rejected with a 400 before validation. Google documents no maximum token length; the cap has been outgrown twice before (#556 raised it 1000 -> 2048). Remove it, keep min_length. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since ~25 Aug 14:00 UTC every socket enquiry POST returns 400: Google reCAPTCHA tokens now exceed the 2048-char cap on
EnquiryModal.grecaptcha_response(observed token: 2489 chars). Zero enquiries have reached TC2 since then.Google documents no maximum token length and the cap has been outgrown twice before (#556 raised it 1000 -> 2048). Remove
max_length, keepmin_length.Test: enquiry with a 4000-char token is accepted and forwarded to the grecaptcha check.