Repository navigation
Skip an already-published morpheus-mail version on tag builds - #564
Merged
Merged
Conversation
…e tag build Every deploy tag runs the publish job, but setup.py's VERSION only changes when the render module does, so tags that don't bump it re-upload an existing version and PyPI returns 400 (v2.0.8-v2.0.11, v2.0.13). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The publish job runs on every deploy tag, but
packaging/morpheus-mail/setup.pyhard-codesVERSION, which only changes when the render module does. Any tag that doesn't bump it rebuilds the same version, and PyPI rejects the re-upload with400 Bad Request. That failed v2.0.13 (2.1.0 was already uploaded by v2.0.12) and v2.0.8 to v2.0.11 before it (2.0.0).twine upload --skip-existingchecks PyPI before uploading and skips files that already exist. Checked locally against the real index with a fake token: both 2.1.0 files are skipped and twine exits 0. A bumpedVERSIONstill uploads as before.🤖 Generated with Claude Code