Repository navigation
Revert "Enhance Global Search with Command Palette and Improve Dark Mode Text Contrast" - #154
Merged
Merged
Conversation
…ode Text Contrast"
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR reverts the earlier “Command Palette / Global Search enhancement + dark mode contrast tweaks” by removing the command palette implementation and rolling back/adjusting several UI theme/style changes across the app.
Changes:
- Removes the
CommandPalettecomponent and its associated context state. - Switches navbar search UI toward the
GlobalSearchcomponent (and updates surrounding navbar/sidebar UI behavior). - Adjusts several theme/style tokens and component classes (dark mode CSS variables, button variants, hover states, legal page badges).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/pages/Terms.tsx | Reverts the hero “Legal & Terms” badge background styling. |
| src/pages/Privacy.tsx | Reverts the hero “Legal & Compliance” badge background styling. |
| src/pages/DashboardPage.tsx | Reverts/adjusts hero text color classes used on the dashboard greeting section. |
| src/index.css | Tweaks dark-mode CSS variables for --border-color and --muted-color. |
| src/context/AppContext.tsx | Removes command-palette state and changes sidebar open initialization; exposes checkProjectDeadlines. |
| src/components/ui/Dropdown.tsx | Adjusts hover background classes for dropdown items/buttons. |
| src/components/ui/CommandPalette.tsx | Deletes the command palette implementation (revert). |
| src/components/ui/Button.tsx | Adjusts the dark button variant styling. |
| src/components/projects/ProjectCard.tsx | Tweaks “+N members” avatar bubble styling. |
| src/components/layouts/Sidebar.tsx | Changes logout click behavior to show a confirmation dialog and adjusts hover background. |
| src/components/layouts/Navbar.tsx | Replaces command-palette-trigger search UI with GlobalSearch and adjusts navbar controls. |
| src/components/layouts/MainLayout.tsx | Removes CommandPalette from the layout tree. |
Comments suppressed due to low confidence (1)
src/components/layouts/Navbar.tsx:19
Sun,Moon, and theisDark/toggleThemelogic are unused in this component. Also, once the mobile search icon button is removed/rewired, theSearchicon import becomes unused as well. This dead code/import noise typically fails linting and makes the component harder to follow.
import { Menu, Search, Plus, Bell, Sun, Moon } from 'lucide-react';
import { Avatar } from '@/components/ui/Avatar';
import { Button } from '@/components/ui/Button';
import { ThemeToggle } from '@/components/ui/ThemeToggle';
import { useApp } from '@/context/AppContext';
import { ROUTES } from '@/constants';
import { GlobalSearch } from './GlobalSearch';
export function Navbar() {
const { sidebarOpen, setSidebarOpen, notifications, profile, settings, updateSettings } = useApp();
const unread = notifications.filter((n) => !n.read).length;
const isDark = settings.theme === 'dark' || (settings.theme === 'system' && window.matchMedia('(prefers-color-scheme: dark)').matches);
const toggleTheme = () => {
const newTheme = isDark ? 'light' : 'dark';
updateSettings({ theme: newTheme });
};
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
12
to
16
| primary: 'bg-primary text-white border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active hover:bg-primary-dark', | ||
| secondary: 'bg-secondary text-white border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active', | ||
| yellow: 'bg-yellow text-ink border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active', | ||
| dark: 'bg-ink text-white dark:text-background border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active', | ||
| dark: 'bg-ink text-white border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active', | ||
| outline: 'bg-surface text-ink border-ink shadow-brutal-sm shadow-brutal-hover shadow-brutal-active hover:bg-background', |
|
|
||
| <div className="relative z-10 max-w-2xl"> | ||
| <span className="inline-block text-xs font-bold uppercase tracking-widest text-ink border-2 border-ink px-3 py-1 bg-surface rounded-full mb-4"> | ||
| <span className="inline-block text-xs font-bold uppercase tracking-widest text-ink border-2 border-ink px-3 py-1 bg-white rounded-full mb-4"> |
|
|
||
| <div className="relative z-10 max-w-2xl"> | ||
| <span className="inline-block text-xs font-bold uppercase tracking-widest text-ink border-2 border-ink px-3 py-1 bg-surface rounded-full mb-4"> | ||
| <span className="inline-block text-xs font-bold uppercase tracking-widest text-ink border-2 border-ink px-3 py-1 bg-white rounded-full mb-4"> |
Comment on lines
+106
to
+107
| const [sidebarOpen, setSidebarOpen] = useState(() => window.innerWidth >= 768); | ||
| const [deletedItems, setDeletedItems] = useState<DeletedItem[]>([]); |
Comment on lines
+30
to
34
| <div className="hidden sm:block flex-1 max-w-md"> | ||
| <GlobalSearch /> </div> | ||
| </div> | ||
|
|
||
| <div className="flex items-center gap-2 sm:gap-3"> |
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #151