chore: bump SDK to v6.0.0 + migrate Config access through GetConfig#140
Closed
kaidaguerre wants to merge 2 commits into
Closed
chore: bump SDK to v6.0.0 + migrate Config access through GetConfig#140kaidaguerre wants to merge 2 commits into
kaidaguerre wants to merge 2 commits into
Conversation
Migrates connection.Config direct reads to connection.GetConfig() per steampipe-plugin-sdk v6.0.0. The SDK now guards Connection.Config under a per-connection sync.RWMutex (see steampipe-plugin-sdk#938) - direct field reads from worker goroutines would race with the SDK's in-place mutation during credential rotation. Bumps go directive to 1.26 (required by SDK v6).
Author
|
Closing — this PR does not fix a customer-visible bug. Slack auth uses a single static OAuth The CHANGELOG entry here was already If a pure dependency-hygiene bump becomes desirable later as routine maintenance, a new PR would be the right shape. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrates
connection.Configdirect reads toconnection.GetConfig()persteampipe-plugin-sdkv6.0.0 (see steampipe-plugin-sdk#938). Slack-side rollout of the same fix that landed for AWS in steampipe-plugin-aws#2756. Build, vet, test, andgo test -raceall green.