Repository navigation
ci: ratchet unwrap/expect, oversized modules and undated cargo-deny ignores - #382
Merged
Merged
Conversation
…gnores Freezes non-test .unwrap() and .expect( at today's counts, turns the advisory module-size report into a ratchet on the number of non-allowlisted files over 1500 lines, and requires every deny.toml advisory ignore to carry a review date. The eight existing ignores get 'review by 2027-01-01'. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
75f40c1
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
Ratchetworkflow using the sharedcount-ratchetaction (tuna-os/.github#389), pinned to8ecf20e. Budgets live in.ratchet.toml, seeded at today's counts on main.unwrap.unwrap()in non-test Rust undercrates/expect.expect(in non-test Rust undercrates/oversized-modulesscripts/architecture/module-size.py: files over 1500 lines not inallowlist.txtdeny-undateddeny.tomladvisory ignores without a dated reasonNon-test excludes test/bench/example/fuzz dirs,
*_test.rs/tests.rs, and#[cfg(test)]/#[cfg(all(test, ...))]modules (the earlier 143/111 counts included#[cfg(all(test, unix))]modules, e.g. 55 unwraps incompass-xdg/src/brand.rstests).deny.toml: the 8 undated ignores now end in; review by 2027-01-01(house form, as in gtk-office-suite). The advisory module-size step inrust.yamlis unchanged and still prints per-file warnings.Rules: count > budget fails; count < budget fails with the exact new budget to write (so improvements lock in); a PR that raises a budget or removes a metric needs the
ratchet-raiselabel. A job-summary table shows count/budget/delta.actions.lockregenerated withgh actions-lock.🤖 Generated with Claude Code