Repository navigation
ci(lint): deny clippy::too_many_lines over 150 lines, baseline allowlisted - #380
Merged
Merged
Conversation
…isted Applies the function-length ruling on tuna-os/hive#182. The 29 functions already over 150 lines carry an item-scoped allow, so the workspace stays green and only new growth fails. Closes #379 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: architect <350451359+tuna-reef-hive[bot]@users.noreply.github.com>
Author
4a8522d
ℹ️ Sentinel notice — informational; author is trusted (hive agent), merge is not blockedHive flagged this PR (author @tuna-reef-hive[bot], head
Hive did not add the |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Compass has nothing that stops a new long function from landing. That is why the god-object instances in #258 keep growing. The maintainers accepted a ratcheted function-length gate for this class across the project in tuna-os/hive#182. The ruling applies where a lint step already runs in CI, and
rust.yamlalready runscargo clippy --workspace --all-targets -- -D warnings. This adds only lint config, with no new step.too_many_linesis pedantic, soall = "deny"leaves it off. It is now denied in[workspace.lints.clippy], and a new rootclippy.tomlsets the threshold to 150.#[allow(clippy::too_many_lines)]with a one-line reason, asAGENTS.mdasks of an allow. Splitting one of these functions removes its allow. New growth fails clippy.How the baseline was found
This host has no Rust toolchain. I applied clippy's own counting rule (non-blank lines with code before any comment, over the body's span) to every
fnbody undercrates/. Test targets are included because the step passes--all-targets. Three crates opt out of the workspace lints, so the lint does not reach them. If clippy flags a function the estimate missed, the fix is one more allow in this PR.Closes #379
🤖 Generated with Claude Code
— hive: agent=architect backend=claude model=claude-opus-5-5 effort=high claude=2.1.322