Skip to content

deps: bump rusqlite to 0.43 (SQLite 3.54.1) and rustix to 1.1.6 - #375

Merged
hanthor merged 1 commit into
mainfrom
deps/rusqlite-0.43-sqlite-3.54
Nov 18, 2026
Merged

hanthor merged 1 commit into
mainfrom
deps/rusqlite-0.43-sqlite-3.54

Conversation

@hanthor

@hanthor hanthor commented Nov 18, 2026

Copy link
Copy Markdown
Member

Summary

cargo-deny fails on main for two advisories. This PR fixes both with a bump. No advisory is ignored.

The SQLCipher C now comes from the separate sqlcipher-src crate, which declares MIT AND BSD-3-Clause AND blessing AND WTFPL. deny.toml allows blessing (SQLite public domain) and WTFPL (libtomcrypt) for that crate only. Both are GPL-3.0 compatible. The C in the binary is the same kind of code as before. Only the licence metadata is new.

packaging/flatpak/cargo-sources.json is regenerated with scripts/flatpak/gen-cargo-sources.sh.

Checks run locally

  • cargo deny check: advisories ok, bans ok, licenses ok, sources ok
  • cargo check --workspace --all-targets: ok
  • cargo test -p compass-sqlcipher-sys -p compass-db: all pass (this includes the fuzzy_trigram tokenizer, which compiles against the new SQLCipher headers)

Supersedes #372. Fixes #370.

🤖 Generated with Claude Code

cargo-deny fails on main for two advisories. Both are fixed by a bump.

RUSTSEC-2026-0459 (CVE-2026-119375): libsqlite3-sys 0.39 still built
SQLCipher on SQLite 3.53.4, but libsqlite3-sys 0.40.0 depends on
sqlcipher-src 420.0.0 (SQLCipher 4.20.0, SQLite 3.54.1), which has the
fix. rusqlite 0.43.0 is the release that takes libsqlite3-sys ^0.40. Its
MSRV is 1.89, the same as the workspace.

The SQLCipher C now comes from the sqlcipher-src crate, which declares
"MIT AND BSD-3-Clause AND blessing AND WTFPL". deny.toml allows blessing
and WTFPL for that one crate only. The code in the binary is the same
kind as before; only its licence metadata is new.

RUSTSEC-2026-0486: rustix 1.1.4 -> 1.1.6 (xattr unsound on a zero-length
buffer).

packaging/flatpak/cargo-sources.json is regenerated with
scripts/flatpak/gen-cargo-sources.sh.

Supersedes #372. Fixes #370.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: James Reilly <jreilly1821@gmail.com>
@tuna-reef-hive

Copy link
Copy Markdown
671a0ce

ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blocked

Hive flagged this PR (author @hanthor, head 671a0ce173ea) because it matches behaviors that can override security controls, escalate privileges or damage the codebase. This is a heuristic, not an accusation — a maintainer should confirm the change is intended before it merges.

  • sensitive_path — changes 1 sensitive path(s) (Touches a sensitive path (OWNERS, workflows, policies, hive config, security docs, …))
    • Cargo.toml

Hive did not add the sentinel-alert label because this author is trusted. The finding remains recorded for audit and the dashboard Security tab; set sentinel.trusted_authors_block: true to require the blocking label for trusted authors too.

@tuna-reef-hive tuna-reef-hive Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me; one routing note for a maintainer.

This is the replacement for #372, and the two cannot both land: both rewrite Cargo.lock, deny.toml and packaging/flatpak/cargo-sources.json for the same advisories. #372 clears RUSTSEC-2026-0459 with an exception; this PR clears it by moving to libsqlite3-sys 0.40.0 / sqlcipher-src 420.0.0 (SQLite 3.54.1). Flagging for a maintainer: if you take this one, #372 can be closed in favour of #375. I have not closed anything.

What I checked: the Cargo.toml bump (rusqlite 0.43.0, libsqlite3-sys 0.40.0) against the lock entries, and the sqlcipher-src and rustix 1.1.6 versions and checksums against crates.io (neither is yanked). sqlcipher-src declares MIT AND BSD-3-Clause AND blessing AND WTFPL, so the deny.toml:83 exception for blessing and WTFPL on that crate only is what the license check needs. The project is GPL-3.0-only (Cargo.toml:21).

Not verified: the build and test jobs were still running when I read this.

— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 effort=high claude=2.1.322

@hanthor
hanthor merged commit 93f367d into main Nov 18, 2026
34 checks passed
@hanthor
hanthor deleted the deps/rusqlite-0.43-sqlite-3.54 branch November 18, 2026 19:20
@tuna-reef-hive

Copy link
Copy Markdown

Hive status — updated in place; edits do not notify. Full history is in the Activity Monitor.

Evidence bundle `#375671a0ce` sha256:3dfa6460e5b34e940cd3809be51ed53c2cefdbc3507830a76ce9a3bb091eaf53 — download from the dashboard or `hivectl review evidence #375`.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[sec-check] RUSTSEC-2026-0459 (bundled SQLite) is in Cargo.lock and deny.toml does not record it

1 participant