Repository navigation
deps: bump rusqlite to 0.43 (SQLite 3.54.1) and rustix to 1.1.6 - #375
Conversation
cargo-deny fails on main for two advisories. Both are fixed by a bump. RUSTSEC-2026-0459 (CVE-2026-119375): libsqlite3-sys 0.39 still built SQLCipher on SQLite 3.53.4, but libsqlite3-sys 0.40.0 depends on sqlcipher-src 420.0.0 (SQLCipher 4.20.0, SQLite 3.54.1), which has the fix. rusqlite 0.43.0 is the release that takes libsqlite3-sys ^0.40. Its MSRV is 1.89, the same as the workspace. The SQLCipher C now comes from the sqlcipher-src crate, which declares "MIT AND BSD-3-Clause AND blessing AND WTFPL". deny.toml allows blessing and WTFPL for that one crate only. The code in the binary is the same kind as before; only its licence metadata is new. RUSTSEC-2026-0486: rustix 1.1.4 -> 1.1.6 (xattr unsound on a zero-length buffer). packaging/flatpak/cargo-sources.json is regenerated with scripts/flatpak/gen-cargo-sources.sh. Supersedes #372. Fixes #370. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: James Reilly <jreilly1821@gmail.com>
671a0ce
ℹ️ Sentinel notice — informational; author is trusted (owner), merge is not blockedHive flagged this PR (author @hanthor, head
Hive did not add the |
There was a problem hiding this comment.
Looks correct to me; one routing note for a maintainer.
This is the replacement for #372, and the two cannot both land: both rewrite Cargo.lock, deny.toml and packaging/flatpak/cargo-sources.json for the same advisories. #372 clears RUSTSEC-2026-0459 with an exception; this PR clears it by moving to libsqlite3-sys 0.40.0 / sqlcipher-src 420.0.0 (SQLite 3.54.1). Flagging for a maintainer: if you take this one, #372 can be closed in favour of #375. I have not closed anything.
What I checked: the Cargo.toml bump (rusqlite 0.43.0, libsqlite3-sys 0.40.0) against the lock entries, and the sqlcipher-src and rustix 1.1.6 versions and checksums against crates.io (neither is yanked). sqlcipher-src declares MIT AND BSD-3-Clause AND blessing AND WTFPL, so the deny.toml:83 exception for blessing and WTFPL on that crate only is what the license check needs. The project is GPL-3.0-only (Cargo.toml:21).
Not verified: the build and test jobs were still running when I read this.
— hive: agent=reviewer backend=claude model=claude-sonnet-5-5 effort=high claude=2.1.322
Summary
cargo-denyfails onmainfor two advisories. This PR fixes both with a bump. No advisory is ignored.-walmemory exposure). deps: clear the two advisories that fail cargo-deny (rustix bump, SQLite exception) #372 records an exception becauselibsqlite3-sys0.39 still builds SQLCipher on SQLite 3.53.4. That was true when deps: clear the two advisories that fail cargo-deny (rustix bump, SQLite exception) #372 was written. Since then,libsqlite3-sys0.40.0 depends onsqlcipher-src420.0.0 (SQLCipher 4.20.0, SQLite 3.54.1), which has the fix.rusqlite0.43.0 takeslibsqlite3-sys^0.40. Its MSRV is 1.89, the same as the workspace.rustix1.1.4 -> 1.1.6.The SQLCipher C now comes from the separate
sqlcipher-srccrate, which declaresMIT AND BSD-3-Clause AND blessing AND WTFPL.deny.tomlallowsblessing(SQLite public domain) andWTFPL(libtomcrypt) for that crate only. Both are GPL-3.0 compatible. The C in the binary is the same kind of code as before. Only the licence metadata is new.packaging/flatpak/cargo-sources.jsonis regenerated withscripts/flatpak/gen-cargo-sources.sh.Checks run locally
cargo deny check: advisories ok, bans ok, licenses ok, sources okcargo check --workspace --all-targets: okcargo test -p compass-sqlcipher-sys -p compass-db: all pass (this includes thefuzzy_trigramtokenizer, which compiles against the new SQLCipher headers)Supersedes #372. Fixes #370.
🤖 Generated with Claude Code