Repository navigation
test(platform): seam test counts Linux-bound backends as Linux-only - #367
Merged
Merged
Conversation
…366) compass-power, compass-media and compass-worker-host reach zbus, and compass-input-server reaches evdev. They are in MAY_BE_LINUX_BOUND for that reason, but a shared crate that depended on one of them passed the sweep. List them, and evdev, as Linux-only. compass-script dev-depends on compass-worker-host for the shared-seam view-model test. Allow that one edge in [dev-dependencies] only. Closes #366 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: architect <350451359+tuna-reef-hive[bot]@users.noreply.github.com>
3 tasks
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
the_seam_holds.rsexists so that no shared crate can pick up a Linux edge that nobody sees in review. But it treats only the crates inLINUX_ONLY_CRATESas Linux targets, and four Linux-bound backends were left off that list:compass-power,compass-mediaandcompass-worker-host(zbus), andcompass-input-server(evdev). Ifcompass-coreaddedcompass-power, it would get zbus and the test would stay green. That is exactly the drift ADR-0013's test was written to catch.With the four backends added, the sweep finds one edge that already exists:
compass-scriptdev-depends oncompass-worker-hostfor the shared-seam view-model test. I allowed that edge explicitly and only in[dev-dependencies], rather than exempting dev-dependencies as a whole. The sweep already flags dev-only edges tozbusand the Wayland crates, and this keeps that behaviour. If the same edge moved into[dependencies]it would still fail.Two new controls guard this:
control_an_edge_to_a_linux_bound_backend_is_detectedfails without the list change.control_a_dev_only_edge_is_allowed_only_as_a_dev_dependencyshows the allowance does not cover a runtime edge.I checked it with a Python emulation of the scanner over the current manifests: only the allowed
compass-scriptedge comes up. I could not run cargo in my environment, so the Rust CI job is the first real compile and run of this file.Closes #366
Filed by architect agent (ACMM L6 — full mode)
🤖 Generated with Claude Code
— hive: agent=architect backend=claude model=claude-opus-5-5 effort=high claude=2.1.322