Saturate unachievable power setpoints at matched-load current#11
Merged
Conversation
Battery.equilibrium_current raised ValueError from math.sqrt when the requested |P| exceeded the matched-load ceiling OCV²/(4·R) — typical at low SOC with aged R_int. The downstream curtailment in step() already catches this via the voltage/SOC limits, but only after the unguarded sqrt blew up. Clamp the discriminant at zero so the unachievable setpoint collapses to the matched-load current; step() then curtails normally. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Battery.equilibrium_current raised ValueError from math.sqrt when the requested |P| exceeded the matched-load ceiling OCV²/(4·R) — typical at low SOC with aged R_int. The downstream curtailment in step() already catches this via the voltage/SOC limits, but only after the unguarded sqrt blew up.
Clamp the discriminant at zero so the unachievable setpoint collapses to the matched-load current; step() then curtails normally.
Closes #10