Repository navigation
fix: always notify on countdown end and add a notifications menu entry - #17
Merged
Merged
Conversation
## Summary Make notifications discoverable and dependable. - **Notify whenever a countdown runs out**, also when the timer tab is in view. Hiding them on the visible tab made the feature look broken while testing it. Ending a session with **Done** still does not notify, since you are already there. - **Menu → Settings → Notifications** shows the current state and does the next useful thing: *Turn on notifications* asks the browser, *Notifications on · test* sends a test notification, *Notifications blocked* explains how to allow them in site settings. Covers the case where the first-visit banner was missed or dismissed. - **No hydration error from browser extensions.** Extensions such as ColorZilla add attributes (`cz-shortcut-listen`) to `<body>` before React hydrates; `suppressHydrationWarning` on `<html>`/`<body>` stops the dev error overlay, which was also covering the notification banner. ## Testing - Lint, typecheck, unit tests and build pass. - Browser with a stubbed permission state: menu shows *Turn on notifications* → after allowing shows *Notifications on · test* and the test notification fires; a 1-minute session in a visible tab produced "Focus session complete".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Make notifications discoverable and dependable.
cz-shortcut-listen) to<body>before React hydrates;suppressHydrationWarningon<html>/<body>stops the dev error overlay, which was also covering the notification banner.Testing