Repository navigation
fix(query): anchor relationship counts on declared endpoints - #731
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
github-actions
Bot
added
area-query
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ed502f2f86
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relationship count plans with distinct endpoint labels can put a country name on a Project identifier and reverse LOCATED_IN, returning a plausible zero. Use declared source/target labels to select the counted and anchored sides while preserving same-label relationship behavior and explicit anchor roles.
This is a focused current-main port of the fix and regression cases from PR #618. The original contributor branch is preserved. New commits use the repository-approved GitHub no-reply identity so the identity gate can run without carrying the original commit metadata.
Validation:
bash scripts/ci/run_basic_ci.shon the selected PR integration snapshot, including this exact patch.bash scripts/ci/check-doc-contracts.shpassed.Risk: internal relationship count construction changes for distinct endpoint labels; regression cases cover both supplied plan label orders and same-label in-degree behavior.
Local tracking: seocho-xlo1.
Current-main integration review: preserve conforming concrete endpoint labels (including ontology subtypes) while using declared endpoint classes for orientation. Added three subtype cases covering both plan label orders and explicit source anchoring. Full
bash scripts/ci/run_basic_ci.shand doc contracts passed on the exact current-main state; separate coordination/workspace/chunk regressions: 20 passed. New hosted/paid experiments and live throughput claims are outside this fix.