fix(hotkey): render platform-aware hotkey legend#361
Open
gularsson wants to merge 1 commit into
Open
Conversation
Menu.Hotkey rendered Mac glyphs (⌘ ⌥ ⌃ ⇧) for every platform, leaving Windows, Linux and Chromebook editors with opaque labels that did not match the keys they had to press. modifier() now consults an isMac() check that prefers navigator.userAgentData.platform, falls back to navigator.platform, and finally to navigator.userAgent. The result is captured once at module load as IS_MAC and used as modifier()'s default so the per-render menu path doesn't re-probe the navigator on every action. Mac users keep the Unicode glyphs; everyone else now sees spelled-out modifier names joined by "+", e.g. "Ctrl+Alt+1", "Ctrl+B", "Ctrl+Alt+Up". isMac is also exported from the library entry so consumers can stop reinventing the detection. Refs ELELOG-624
vilindh
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Menu.Hotkey rendered Mac glyphs (⌘ ⌥ ⌃ ⇧) for every platform, leaving Windows, Linux and Chromebook editors with opaque labels that did not match the keys they had to press.
modifier() now consults an isMac() check that prefers navigator.userAgentData.platform, falls back to navigator.platform, and finally to navigator.userAgent. The result is captured once at module load as IS_MAC and used as modifier()'s default so the per-render menu path doesn't re-probe the navigator on every action. Mac users keep the Unicode glyphs; everyone else now sees spelled-out modifier names joined by "+", e.g. "Ctrl+Alt+1", "Ctrl+B", "Ctrl+Alt+Up".
isMac is also exported from the library entry so consumers can stop reinventing the detection.
Refs ELELOG-624