use "#" instead of "+" as the variant type separator#8
Merged
Conversation
The "+" separator for document type variants (e.g. "core/article+template") collides with existing compound document types like "core/article+meta" where "+" is already part of the base type name. Switch to "#" as the separator, borrowing from URL fragment semantics where a fragment refers to "the same resource, but a different view". This makes "core/article#template" unambiguous — the part after "#" is always the variant suffix. Also removes the obsolete update-test-results.sh and update-entities.sh shell scripts. The CLI no longer has a "document" subcommand, so update-test-results.sh would silently overwrite golden files with empty output. The tests already support regeneration natively via REGENERATE=true.
hugowetterberg
added a commit
to ttab/elephant-repository
that referenced
this pull request
Mar 5, 2026
The "+" variant syntax (e.g. "core/article+template") collides with existing meta document types like "core/article+meta", causing them to be incorrectly interpreted as variants. Switch to "#" as the variant separator (e.g. "core/article#template"), borrowing from URL fragment semantics of "same resource, but different representation". Updates revisor to v0.11.1-pre1 which implements the separator change in the resolveVariant parsing logic. See ttab/revisor#8
hugowetterberg
added a commit
to ttab/elephant-repository
that referenced
this pull request
Mar 5, 2026
The "+" variant syntax (e.g. "core/article+template") collides with existing meta document types like "core/article+meta", causing them to be incorrectly interpreted as variants. Switch to "#" as the variant separator (e.g. "core/article#template"), borrowing from URL fragment semantics of "same resource, but different representation". Updates revisor to v0.11.1-pre1 which implements the separator change in the resolveVariant parsing logic. See ttab/revisor#8
hugowetterberg
added a commit
to ttab/elephant-repository
that referenced
this pull request
Mar 6, 2026
The "+" variant syntax (e.g. "core/article+template") collides with existing meta document types like "core/article+meta", causing them to be incorrectly interpreted as variants. Switch to "#" as the variant separator (e.g. "core/article#template"), borrowing from URL fragment semantics of "same resource, but different representation". Updates revisor to v0.11.1-pre1 which implements the separator change in the resolveVariant parsing logic. See ttab/revisor#8
hugowetterberg
added a commit
to ttab/elephant-index
that referenced
this pull request
Mar 6, 2026
The "+" separator for document type variants (e.g. "core/article+template") collides with existing article meta document types like "core/article+meta" where "+" is already part of the type name. Switch to "#" as the variant separator, borrowing from URL fragment semantics of "same resource, but different view". The index name mapping is unchanged: "core/article#template" still becomes "core_article--template" in OpenSearch. Updates the revisor dependency to v0.11.1-pre1 which uses the new separator (ttab/revisor#8).
hugowetterberg
added a commit
to ttab/elephant-repository
that referenced
this pull request
Mar 6, 2026
* switch variant separator from "+" to "#" The "+" variant syntax (e.g. "core/article+template") collides with existing meta document types like "core/article+meta", causing them to be incorrectly interpreted as variants. Switch to "#" as the variant separator (e.g. "core/article#template"), borrowing from URL fragment semantics of "same resource, but different representation". Updates revisor to v0.11.1-pre1 which implements the separator change in the resolveVariant parsing logic. See ttab/revisor#8 * update revisor to v0.11.1 release
hugowetterberg
added a commit
to ttab/elephant-index
that referenced
this pull request
Mar 6, 2026
* use "#" instead of "+" as the document type variant separator The "+" separator for document type variants (e.g. "core/article+template") collides with existing article meta document types like "core/article+meta" where "+" is already part of the type name. Switch to "#" as the variant separator, borrowing from URL fragment semantics of "same resource, but different view". The index name mapping is unchanged: "core/article#template" still becomes "core_article--template" in OpenSearch. Updates the revisor dependency to v0.11.1-pre1 which uses the new separator (ttab/revisor#8). * update revisor to v0.11.1 release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "+" separator for document type variants (e.g. "core/article+template") collides with existing compound document types like "core/article+meta" where "+" is already part of the base type name.
Switch to "#" as the separator, borrowing from URL fragment semantics where a fragment refers to "the same resource, but a different view". This makes "core/article#template" unambiguous — the part after "#" is always the variant suffix.
Also removes the obsolete update-test-results.sh and update-entities.sh shell scripts. The CLI no longer has a "document" subcommand, so update-test-results.sh would silently overwrite golden files with empty output. The tests already support regeneration natively via REGENERATE=true.