fix(planning): remove misleading button affordance from readOnly Assi…#2644
Open
gularsson wants to merge 1 commit into
Open
Conversation
…gnmentType When opening the move/date-change dialog on a planning item, each assignment row showed its assignment-type icon (e.g. Flash/ZapIcon) rendered inside a `Button variant='icon'` with hover background and focus ring styles. Because the readOnly variant attaches no onClick, the icons looked interactive but did nothing - confusing to users who expected a button to do something on click. Replace the Button wrapper in the readOnly branch with a plain non- interactive `<span>` that preserves layout/spacing but drops the button semantics, hover background, and focus ring. The aria-label keeps the icon labelled for assistive tech. Refs ELELOG-487
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…gnmentType
When opening the move/date-change dialog on a planning item, each assignment row showed its assignment-type icon (e.g. Flash/ZapIcon) rendered inside a
Button variant='icon'with hover background and focus ring styles. Because the readOnly variant attaches no onClick, the icons looked interactive but did nothing - confusing to users who expected a button to do something on click.Replace the Button wrapper in the readOnly branch with a plain non- interactive
<span>that preserves layout/spacing but drops the button semantics, hover background, and focus ring. The aria-label keeps the icon labelled for assistive tech.Refs ELELOG-487