fix(print): clear stuck unpublished status after status transitions#2643
Open
gularsson wants to merge 1 commit into
Open
fix(print): clear stuck unpublished status after status transitions#2643gularsson wants to merge 1 commit into
gularsson wants to merge 1 commit into
Conversation
The print articles workflow status column read workflow_checkpoint with workflow_state as a fallback in its cell renderer, while the accessor read workflow_state only. The subscription polling in useDocuments applies optimistic field updates by spreading the payload over the existing fields object, so a workflow_checkpoint='unpublished' set during an unpublish step is preserved across subsequent transitions (usable -> unpublish -> done) unless the index update happens to echo the field back. The result was a row pinned to "unpublished" even though its underlying workflow_state had advanced. Align the cell with the accessor: both now read workflow_state. The "unpublished" visual still renders because workflow_state itself is 'unpublished' when a document is unpublished (already covered by getStatusFromMeta). Refs ELELOG-403.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The print articles workflow status column read workflow_checkpoint with workflow_state as a fallback in its cell renderer, while the accessor read workflow_state only. The subscription polling in useDocuments applies optimistic field updates by spreading the payload over the existing fields object, so a workflow_checkpoint='unpublished' set during an unpublish step is preserved across subsequent transitions (usable -> unpublish -> done) unless the index update happens to echo the field back. The result was a row pinned to "unpublished" even though its underlying workflow_state had advanced.
Align the cell with the accessor: both now read workflow_state. The "unpublished" visual still renders because workflow_state itself is 'unpublished' when a document is unpublished (already covered by getStatusFromMeta).
Refs ELELOG-403.