fix(factboxes): surface bulk-get batch failures instead of silently d…#2624
Open
vilindh wants to merge 1 commit into
Open
fix(factboxes): surface bulk-get batch failures instead of silently d…#2624vilindh wants to merge 1 commit into
vilindh wants to merge 1 commit into
Conversation
…ropping rows Switch the per-article bulk-get to Promise.allSettled and log a warning with the batch's article ids when a batch rejects or resolves to null. Previously the defensive `response?.items ?? []` collapsed a failed batch into an empty list, so embedded factboxes for those articles vanished from search without any signal to devs or users. Standalone factboxes and successful batches still merge in as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ropping rows
Switch the per-article bulk-get to Promise.allSettled and log a warning with the batch's article ids when a batch rejects or resolves to null. Previously the defensive
response?.items ?? []collapsed a failed batch into an empty list, so embedded factboxes for those articles vanished from search without any signal to devs or users. Standalone factboxes and successful batches still merge in as before.