Feature/elelog 683 timelesscategoryselect swallows deselection#2609
Open
gularsson wants to merge 2 commits into
Open
Feature/elelog 683 timelesscategoryselect swallows deselection#2609gularsson wants to merge 2 commits into
gularsson wants to merge 2 commits into
Conversation
The wrapper guarded against falsy values before calling onChange, so the ComboBox's deselect signal (an undefined emit when an already-selected option is clicked) was dropped. The parent retained stale state and the dialog's primary stayed enabled. Widen the contract to (Block | undefined) and forward all values. Both existing callers (ConvertToTimelessDialog, CreateDeliverablePrompt) already type their state as Block | undefined, so they pick up the deselect cleanly.
vilindh
approved these changes
May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.