fix CJK text width estimation#19
Open
reallav0 wants to merge 4 commits into
Open
Conversation
Document the Unicode width coverage added for issue tt-a1i#14.
Owner
|
Thanks for the PR — looked at this carefully against #14. For the Chinese labels called out in that issue ( What it does change is broader Unicode coverage (vertical punctuation, Tangut/Nushu/Khitan, etc.). That also shifts width for ~tens of thousands of code points, including some that shouldn't be double-width in our monospace stack (e.g. middle dot So I'm going to hold off on merging this as a
Happy to take another look with either a repro or a tightened version. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
archify.zipRoot cause
The previous classifier covered common BMP Han ranges and supplementary unified ideographs, but skipped several supplementary East Asian scripts and U+FE10–U+FE19 vertical punctuation. Those glyphs were counted as one unit, which could underestimate label and collision-box widths.
Validation
npm run check:validatorsnode --test test/*.test.mjs— 111 tests passedarchify --help,archify doctor, and architecture validation smoke checksCloses #14