Repository navigation
Conversation
|
How do you know this works with Eloquence 64 properly if you didn't test it with running NVDA? |
Contributor
Author
|
@trypsynth I have tested the patched add-on in a running NVDA instance with Eloquence 64, and it works well. The Shorten pauses setting remains at Always after switching to another synth and back. The description did not reflect that manual testing; I have updated its Validation section to include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switching away from Eloquence 64 and back through SwitchSynth reset its Shorten pauses setting from Always to Never. Older saved slots did not contain Eloquence's newer
pauseModesetting, and loading a slot replaced the entire synthesizer configuration with that incomplete snapshot, causing the missing setting to fall back to its default.This fixes settings preservation generically, without special-casing Eloquence or any setting name:
Explicitly saved values still take priority: changing an option already stored in a slot requires saving that slot again. The fix covers settings stored in NVDA's per-synth configuration; it does not capture unrelated add-on configuration sections or external files.
Also document the restore behavior, add regression tests, and bump the patch version from 1.07.0 to 1.07.1.
Validation
python -m unittest discover -s tests -v: all 9 tests pass, covering the Eloquence pause-setting round trip, newly added settings, explicit slot overrides, reloading the same synth, live values when saving, nested settings, configuration profiles, and empty slots.python -m SCons: builtswitchSynth-1.07.1.nvda-addon; verified the packaged source, version, and archive integrity.