Check current compiler at the start of the nob to avoid confusion with clang #135
+21
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KillerxDBr
reviewed
Jan 8, 2026
nob.h
Outdated
| # if defined(__GNUC__) | ||
| # define nob_cc(cmd) nob_cmd_append(cmd, "cc") | ||
| # elif defined(__clang__) | ||
| # if defined(__GNUC__) && defined(__clang__) |
Contributor
There was a problem hiding this comment.
This will probably break Visual Studio Clang, since it defines _MSC_VER, and MinGW Clang defines __GNUC__
Author
There was a problem hiding this comment.
Is that the only case where those flags can exist at the same time?
Author
There was a problem hiding this comment.
Cause if its something that happens in mutiple places it be cool to do something like this
# if defined(__clang__)
# define COMPILER_CLANG
# elif defined(_MSC_VER)
# define COMPILER_MSVC
# elif defined(__TINYC__)
# define COMPILER_TINYC
# elif defined(__GNUC__)
# define COMPILER_GCC
# endifAs i understood clang is the trouble maker so we just need to check it first?
This also doubles down as documentation
…ves as in code documentation
CaitaXD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think cc is a Unix thing, when compiling with it mingw should be just gcc.