fix: ts-trueskillとscrape-itをセキュリティアップデート#1212
Open
hakatashi wants to merge 3 commits into
Open
Conversation
- ts-trueskill v4 → v5 (moderate脆弱性対応) - scrape-it v5 → v6 (high/moderate脆弱性対応、cheerio/jsdom等の間接依存を解決) - scrape-it v6ではcheerio-req v2がtinyreqではなくaxiosを使用するため、 影響テスト(room-gacha, lyrics)のモック実装をaxiosベースに更新 Closes: #1211 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
えへ～ ありがとう！ レビューさせてもらうにゃ！ |
Contributor
|
🤖 I'm sorry @hakatashi, but I was unable to process your request. Please see the logs for more details. |
any型の使用を避けるため、room-gacha/index.test.tsとlyrics/index.test.tsの axiosモック操作をjest.mocked(axios)経由のmockResolvedValue/mockImplementationに変更。 lyricsではaxios.get分離を廃止し、scrape-itとiTunes APIの両呼び出しを 単一のmockImplementationで処理するよう整理。 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- url引数に明示的なstring型を付与し(url as string)キャストを削除 - as unknown as AxiosResponseをas AxiosResponseに簡略化 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Contributor
|
えへ～ ありがとう！ レビューさせてもらうにゃ！ |
Contributor
|
🤖 I'm sorry @hakatashi, but I was unable to process your request. Please see the logs for more details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
Issue #1211 で整理された未対応アップデートのうち、影響範囲が小さい2パッケージを対応。
ts-trueskillv4 → v5: moderate脆弱性対応。API互換性あり、dynamic importのため変更なしscrape-itv5 → v6: high/moderate脆弱性対応。cheerio、jsdom、css-select、cheerio-req等の間接依存を解決変更内容
パッケージ更新
ts-trueskill:^4.1.0→^5.1.0scrape-it:^5.3.2→^6.1.12テスト修正
scrape-itv6 ではcheerio-reqが v2 に更新され、HTTPリクエストがtinyreqからaxiosへ変更されたため、影響するテストのモック実装を更新:room-gacha/index.test.ts:tinyreqモック →axiosモックへ変更lyrics/index.test.ts:tinyreqモック →axios.mockImplementationへ変更🤖 Generated with Claude Code