Fix silkscreen knockout text rendering#747
Fix silkscreen knockout text rendering#747rushabhcodes wants to merge 4 commits intotscircuit:mainfrom
Conversation
rushabhcodes
requested review from
Abse2001 and
ShiboSoftwareDev
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
why is one of them called CUSTOM_PAD? (makes no sense?)
Also it looks wrong- the knockout padding clearly doesn't correspond with the text inside, the right and bottom padding are incorrect relative to the left and top padding
|
@seveibar I just copied @Abse2001 's example for copper knockout text https://tscircuit-3d-viewer.vercel.app/?path=/story/copper-text--copper-text-knockout |
ig this is a circuit-to-canvas issue, i will investigate more |
|
updating |
Summary
This PR fixes silkscreen knockout text so it behaves like copper knockout text in the 3D viewer.
Previously, silkscreen knockout text could appear black instead of revealing the board background. The silkscreen texture path now performs a knockout cutout pass that removes the glyph strokes from the
silkscreen texture, so knockout text shows the board color underneath as expected.
Before
After