Skip to content

🧪 Add tests for MemoryDb::correct - #9

Closed
undivisible wants to merge 1 commit into
mainfrom
add-memorydb-correct-tests-15766242000013295926
Closed

🧪 Add tests for MemoryDb::correct#9
undivisible wants to merge 1 commit into
mainfrom
add-memorydb-correct-tests-15766242000013295926

Conversation

@undivisible

@undivisible undivisible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🎯 What: Missing tests for the MemoryDb::correct method.
📊 Coverage: Added explicit coverage for tenant_id and person_id validation, empty text and value validation, timestamp advancement validation, and happy path assertions to ensure old claims are superseded and new claims are successfully accepted.
Result: Test coverage improved specifically for the correct method with deterministic outputs that ensure core logic regressions can be avoided during refactoring.


PR created automatically by Jules for task 15766242000013295926 started by @undivisible


Note

Low Risk
Test-only changes with no production code modifications.

Overview
Adds focused unit tests for MemoryDb::correct, covering input validation and the happy-path supersede flow.

New cases assert that empty tenant_id/person_id, empty text/value, and non-advancing timestamps are rejected as Error::Invalid, and that a successful correction marks the old claim superseded while creating an accepted replacement with the updated value and intervals.

Reviewed by Cursor Bugbot for commit 38e610e. Configure here.

Tested edge cases and happy path, significantly improving coverage.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_1b3875b8-d5f6-4350-ac47-41e2c005cb6f)

Copy link
Copy Markdown
Contributor Author

Superseded by the reviewed and merged integration in #22.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded by the reviewed and merged integration in #22.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant