Skip to content

🧪 [testing improvement] Add tests for repair_projections - #5

Closed
undivisible wants to merge 2 commits into
mainfrom
test-repair-projections-14172526879755234929
Closed

🧪 [testing improvement] Add tests for repair_projections#5
undivisible wants to merge 2 commits into
mainfrom
test-repair-projections-14172526879755234929

Conversation

@undivisible

@undivisible undivisible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🎯 What: Added tests for the MemoryDb::repair_projections function to address the testing gap.
📊 Coverage: Covered 4 scenarios: empty outbox, stale embeddings on target modification, embeddings cleanup on target deletion (NotFound), and handling of invalid target kinds.
Result: Improved test coverage for database corruption and projection repair mechanisms.


PR created automatically by Jules for task 14172526879755234929 started by @undivisible


Note

Low Risk
Test-only changes with no production code modifications.

Overview
Adds unit tests for MemoryDb::repair_projections in a new repair test module.

Covers four cases: empty outbox, deleting stale embeddings after target modification, cleaning up embeddings and FTS when the target is gone, and marking invalid outbox entries as processed.

Reviewed by Cursor Bugbot for commit 4e60f52. Configure here.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_ef01756a-6f0c-4db4-8983-a0598506834e)

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

Superseded by the reviewed and merged integration in #22.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded by the reviewed and merged integration in #22.

Understood. Acknowledging that this work is now obsolete and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant