Skip to content

🧪 Add tests for record_identity function - #19

Closed
undivisible wants to merge 3 commits into
mainfrom
test-record-identity-12610874186124021177
Closed

🧪 Add tests for record_identity function#19
undivisible wants to merge 3 commits into
mainfrom
test-record-identity-12610874186124021177

Conversation

@undivisible

@undivisible undivisible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The record_identity function in src/store/apply.rs was missing dedicated unit tests to verify that it maps ExportRecord enum variants to the correct string identifiers.

📊 Coverage: A new test test_record_identity has been added in src/store/tests/apply.rs. The test provides coverage for the following variants of ExportRecord:

  • Source
  • Evidence
  • Claim
  • ClaimEvidence
  • Correction
  • Profile
  • DailyReview
  • Deletion

Result: Increased test coverage for ExportRecord identity mapping, making future refactoring safer and ensuring string identifiers for export records remain consistent and reliable. The function visibility was changed to pub(crate) to allow testing.


PR created automatically by Jules for task 12610874186124021177 started by @undivisible


Note

Low Risk
Test-only change plus a visibility bump; no production behavior is altered.

Overview
Adds dedicated unit coverage for record_identity, which maps each ExportRecord variant to its kind/id pair used during apply deduplication.

Makes record_identity pub(crate) so the new test_record_identity can assert the expected identifiers for Source, Evidence, Claim, ClaimEvidence, Correction, Profile, DailyReview, and Deletion.

Reviewed by Cursor Bugbot for commit 365ab86. Configure here.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_5bed57e0-2876-430c-96c9-78000e4b56fb)

google-labs-jules Bot and others added 2 commits August 12, 2026 02:27
Fix test string format to match expected output and run cargo fmt.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
Fix test string format to match expected output and run cargo fmt.

Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>

Copy link
Copy Markdown
Contributor Author

Superseded by the reviewed and merged integration in #22.

@google-labs-jules

Copy link
Copy Markdown
Contributor

Superseded by the reviewed and merged integration in #22.

Understood. Acknowledging that this work is superseded by #22 and stopping work on this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant