🧪 Improve test coverage for CLI JSON parsing and execution failures - #17
🧪 Improve test coverage for CLI JSON parsing and execution failures#17undivisible wants to merge 1 commit into
Conversation
Replaced a verbose 15-line test that dynamically generated a mock `zkr` script with two concise tests using standard shell commands (`echo` and `false`). These simple tests successfully trigger the JSON parsing error path and the non-zero exit code error path in `cli.ts`, improving test maintainability and driving coverage to 100%. Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_b744258d-2c11-4577-9b50-e867279b9013) |
|
Superseded by the reviewed and merged integration in #22. |
1 participant
🎯 What: Addressed the testing gap in
runZkrCLI error paths by replacing verbose mocked scripts with standard bash commands (echoandfalse).📊 Coverage: Covered the CLI failing with a non-zero exit code, and the CLI succeeding but outputting invalid JSON.
✨ Result:
plugins/openclaw/cli.tstest coverage is now at 100%, and the tests are much easier to read and maintain.PR created automatically by Jules for task 16110011709295730757 started by @undivisible
Note
Low Risk
Test-only changes with no production code, auth, or data-handling impact.
Overview
Improves
runZkrfailure-path coverage with simpler, more maintainable tests.Replaces the temp-script malformed-output case with
echo, and adds a new test that usesfalseto assert non-zero CLI exits are rejected asZKR_COMMAND_FAILED.Reviewed by Cursor Bugbot for commit a275f20. Configure here.