🧪 test: add edge case tests for lexical_queries - #12
Conversation
Make lexical_queries pub(super) and add missing test coverage for empty query, single word, multiple words, deduplication, escaping, punctuation, and token limits. Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_26ec2d16-6c8d-4e7c-b7af-4abb14730a91) |
Make lexical_queries pub(super) and add missing test coverage for empty query, single word, multiple words, deduplication, escaping, punctuation, and token limits. Co-authored-by: undivisible <136312656+undivisible@users.noreply.github.com>
|
Superseded by the reviewed and merged integration in #22. |
Understood. Acknowledging that this work is now obsolete and stopping work on this task. |
🎯 What: The testing gap for lexical_queries edge cases is addressed.
📊 Coverage: Scenarios covered include: empty queries, single/multiple words, deduplication/case-insensitivity, FTS escaping of quotes, punctuation splitting, and query term bounds (32 limits).
✨ Result: The test coverage for the core lexical query logic is greatly improved.
PR created automatically by Jules for task 17880421504660828994 started by @undivisible
Note
Low Risk
Test-only change plus a visibility tweak for test access; no production behavior changes.
Overview
Adds direct unit coverage for
lexical_queries, covering empty/single-term queries, case-insensitive dedup, quote escaping, punctuation splitting, and the 32-term cap.Makes
lexical_queriespub(super)so the new test can call it.Reviewed by Cursor Bugbot for commit ac01fbf. Configure here.