Skip to content

🧪 Add tests for native link resolution - #272

Open
undivisible wants to merge 1 commit into
masterfrom
test-native-link-tests-8410740789915434746
Open

🧪 Add tests for native link resolution#272
undivisible wants to merge 1 commit into
masterfrom
test-native-link-tests-8410740789915434746

Conversation

@undivisible

@undivisible undivisible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🎯 What: Added tests for resolve_native_fn in native_link.rs to test allowlist symbols, disallowed symbols, and the caching mechanism.
📊 Coverage: Covered happy paths (allowlisted symbols returning Some), edge cases (unknown/disallowed returning None), and cache interaction.
Result: Improved testing coverage for native symbol resolution logic, ensuring no regressions when evaluating dynamic native functions.


PR created automatically by Jules for task 8410740789915434746 started by @undivisible


Note

Low Risk
Test-only additions; no changes to JIT native symbol resolution or security allowlist behavior in production code.

Overview
Adds a #[cfg(test)] module in native_link.rs with unit tests for resolve_native_fn.

On non-Windows, an allowlisted symbol (exit) is expected to resolve to Some. system must return None (not on the dlsym allowlist). A third test seeds the resolver cache with a fake name and checks that resolve_native_fn returns the cached pointer without going through allowlist/dlsym logic.

Reviewed by Cursor Bugbot for commit a316c7f. Configure here.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_2e34c2ec-2ed1-48f9-8404-6f225bd95e62)

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant