Skip to content

🧪 Test split_top_level_decl_blocks comprehensively - #266

Open
undivisible wants to merge 1 commit into
masterfrom
test-split-top-level-decl-blocks-16056898184563694510
Open

🧪 Test split_top_level_decl_blocks comprehensively#266
undivisible wants to merge 1 commit into
masterfrom
test-split-top-level-decl-blocks-16056898184563694510

Conversation

@undivisible

@undivisible undivisible commented Aug 12, 2026

Copy link
Copy Markdown
Contributor

🎯 What: The testing gap in split_top_level_decl_blocks missing dedicated tests in in-cli/src/in_lang_parse/tests.rs is addressed.
📊 Coverage: Empty sources, single declarations, multiple declarations with mixed spacing, declarations with nested braces (e.g. struct with internal functions), and declarations mixed with comments are now thoroughly tested.
Result: Test coverage is significantly improved and regressions in top-level block splitting will be reliably caught.


PR created automatically by Jules for task 16056898184563694510 started by @undivisible


Note

Low Risk
Test-only changes in the parser test module; no production code paths are modified.

Overview
Adds five dedicated unit tests for split_top_level_decl_blocks in in-cli/src/in_lang_parse/tests.rs, ahead of the existing ignores_nested_fn_at_nonzero_depth test.

The new cases lock in empty input, a single top-level decl, multiple decls separated by blank lines (including 1-based start line metadata), brace-balanced splitting so inner fn inside a struct stays in one block, and leading line comments so only the declaration line is captured. No parser or lexer behavior is changed—coverage only.

Reviewed by Cursor Bugbot for commit 31fc32f. Configure here.

This commit adds a suite of unit tests in `in-cli/src/in_lang_parse/tests.rs`
to thoroughly verify the behavior of `split_top_level_decl_blocks`.

It covers various scenarios including empty source, single declarations,
multiple declarations with different spacing, declarations with nested
braces (like inner functions), and comment handling.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@cursor

cursor Bot commented Aug 12, 2026

Copy link
Copy Markdown

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_461dca9c-5c7e-4324-97f7-44c1313fbab5)

@mergify

mergify Bot commented Aug 12, 2026

Copy link
Copy Markdown

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant