Repository navigation
feat: add 8.12 annotation layout opt-ins - #135
Merged
rileyhilliard merged 3 commits intoOct 17, 2026
Merged
Conversation
Checkpoint reviewed 8.12 implementation and regressions. D19 rule/range defaults remain pending a binding-plan clarification: legacy normalization still overrides these two tokens, and the custom-token test intentionally remains failing until that decision. Do not open the phase PR until all gates pass.
Use the approved existing rule and range colors in both modes. Resolve omitted ink through theme tokens instead of stamping it during normalization, preserving explicit annotation overrides and default visual output.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Authors can opt into wrapped callouts, compact callout limits, and contained reference labels without changing charts that omit the new fields. Faceted grow layouts now preserve the plot budget and count chrome and notes once through rendering, auto-height mounting, and export.
Stacked on #134, which is stacked on #133. Together these PRs cover Track A phases 1–3; this diff completes the 8.12 phase.
Implementation checklist
maxWidth,subtitleFontSize, andresponsive.compactAnnotationLimit, preserving omitted/null behavior, rich text identity, priority/source ordering, pinned exemptions, and D15 compact opt-outs.labelPlacementwith start/end, auto containment, and outside gutters/lanes. Facet cells reserve their own space before axes/scales/marks; displaced horizontal leaders stay in the gutter during layout and animation. Authored offsets remain pinned.#666666/#000000) in both modes.noteBandHeight; deprecate bothfootnoteBandHeighthelpers with JSDoc and once-per-process warnings, preserving compatibility and migrating internal callers. Framework wrapper lifecycle/sizing coverage is included.migrateSpecV8default materialization, with all-example and targeted render-parity fixtures.Validation
bun run test: 322 files, 5,786 passed tests, 3 existing expected failures.bun run lint,bun run typecheck,bun run build,bun run check:generated: pass.bun run test:visual: 106/106 passed, zero baseline changes.Plan corrections and limits
The D19 table originally quoted resolver fallback colors that normalization bypassed. The user approved matching actual compiled ink instead, preserving zero visual diff while making the new tokens effective. Existing subdued dark reference ink is intentionally retained.
noteBandHeightalready exists from 8.11 and is reused. Core's legacy helper retains its numeric signature; the new nondeprecated arithmetic helper also accepts resolved metadata. RootLayerSpechas nochromeLayout, so layered sizing remains authored on the first leaf or compile options. Range labels retain their existing behavior because this phase adds no range-placement opt-in.Three structural snapshots add only resolved theme metadata. No 8.12 visual baselines are changed. The screenshot harness repeats its existing development-toolbar hiding during capture to prevent intermittent overlays, without masking chart content or loosening thresholds. No v9/D14 retunes, Studio work, release/publishing, or external skill sync is included.