Fix reid track pruning bug Issue 325#326
Open
robbinsa530 wants to merge 1 commit intotryolabs:masterfrom
Open
Conversation
robbinsa530
commented
Dec 6, 2024
| assert tracked_objects[0].reid_hit_counter is None | ||
|
|
||
| # check that after reid_hit_counter_max more updates, object still exists | ||
| for _ in range(reid_hit_counter_max + 2): |
Author
There was a problem hiding this comment.
+2 because with the bug,
- After
reid_hit_counter_maxupdates,reid_hit_counterwill be 0 - After
reid_hit_counter_max+ 1 updates,reid_hit_counterwill be -1 but because of the bug,hit_counterwill be positive at the end of the update call, so the tracked object will still be returned and alive - At the start of the
reid_hit_counter_max+ 2 update,reid_hit_counterwill be -1 and the tracked object will be marked as dead and won't be sent for normal matching
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue 325