Allow for giving a single score for the whole object#295
Open
Allow for giving a single score for the whole object#295
Conversation
javiber
approved these changes
Feb 26, 2024
Collaborator
javiber
left a comment
javiber
left a comment
There was a problem hiding this comment.
LGTM just a single question regarding the points doc change
| ---------- | ||
| points : np.ndarray | ||
| Points detected. Must be a rank 2 array with shape `(n_points, n_dimensions)` where n_dimensions is 2 or 3. | ||
| Points detected. Must be a rank 2 array with shape `(n_points, n_dimensions)`. |
Collaborator
Author
There was a problem hiding this comment.
The thing is that it is not actually a restriction to have dimension 2 or 3. You can have any dimension you want. I decided to change that description since I was already modifying the Detection class anyway
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Creating an array of scores might be a little annoying considering that is quite common to only have a single score for the whole detection. This modification is to allow the user to provide either a single number (float or int) or a numpy array of scores.