Allocations clean up#403
Merged
Merged
Conversation
uuuvn
requested changes
May 13, 2026
Comment on lines
56
to
60
| MoePassATileCountsArguments { | ||
| expert_offsets: args.expert_offsets, | ||
| tile_counts: &mut *args.tile_counts, | ||
| e: args.e, | ||
| h_blocks, | ||
| }, |
Contributor
There was a problem hiding this comment.
Very small struct, I think it's going to be cleaner if the 3 arguments are just arguments of the function instead of one argument with a 3-field struct
Comment on lines
65
to
67
| MoePassATileScanArguments { | ||
| tile_counts: &*args.tile_counts, | ||
| tile_offsets: &mut *args.tile_offsets, | ||
| total_tiles: &mut *args.total_tiles, | ||
| tile_counts: &tile_counts, | ||
| e: args.e, |
Contributor
There was a problem hiding this comment.
Very small struct, I think it's going to be cleaner if the 2 arguments are just arguments of the function instead of one argument with a 2-field struct
Same in a bunch of places below too, won't spam comments on each one
uuuvn
approved these changes
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moved variables closer to where they are used
Separated scratch from inputs allocations, removing them from arguments