Skip to content

Bump Ghostty to v1.3.1#36

Merged
trydis merged 2 commits intomainfrom
bump-ghostty
Mar 18, 2026
Merged

Bump Ghostty to v1.3.1#36
trydis merged 2 commits intomainfrom
bump-ghostty

Conversation

@trydis
Copy link
Owner

@trydis trydis commented Mar 18, 2026

Summary by CodeRabbit

  • Chores
    • Improved clipboard request handling reliability with enhanced error management and documentation updates.
    • Updated dependencies to latest versions.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: b7cbd536-cbcd-4b9c-b29c-018bce500c23

📥 Commits

Reviewing files that changed from the base of the PR and between 5fa3a73 and 45644a9.

📒 Files selected for processing (2)
  • Sources/Shellraiser/Infrastructure/Ghostty/GhosttyRuntime.swift
  • ghostty

📝 Walkthrough

Walkthrough

The readClipboard callback in the Ghostty runtime is modified to return a Bool indicating success or failure, replacing the void return type. The callback now returns false when the host view cannot be resolved and true after successfully completing the clipboard request on the main actor. A submodule dependency is also updated to a newer commit.

Changes

Cohort / File(s) Summary
Ghostty Runtime Clipboard Handler
Sources/Shellraiser/Infrastructure/Ghostty/GhosttyRuntime.swift
Modified readClipboard callback to return Bool instead of Void, signaling ownership and success/failure of clipboard requests. Returns false on host view resolution failure, true after completing clipboard request on main actor.
Submodule Update
ghostty
Updated submodule pointer to a newer commit with no functional changes.
🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The pull request title accurately describes the main change: updating the Ghostty submodule to version v1.3.1. This is the primary modification visible in the changeset.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bump-ghostty
📝 Coding Plan
  • Generate coding plan for human review comments

Comment @coderabbitai help to get the list of available commands and usage tips.

@trydis trydis merged commit 6dd6aae into main Mar 18, 2026
2 checks passed
@trydis trydis deleted the bump-ghostty branch March 18, 2026 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant