Add dock icon badge for pending completion count

[trydis]

Sets NSApp.dockTile.badgeLabel at every pending-count mutation site (enqueue, agent start, activate/close surface, load/delete workspace) so the dock icon always reflects the live pending completion count.

Summary by CodeRabbit

• New Features
  • The app's dock badge now displays the count of pending completions, giving you quick visibility into outstanding tasks. The badge automatically updates throughout your workflow—when completions are enqueued, when surfaces are activated or closed, and when workspaces are loaded or deleted—keeping you informed at all times.

[coderabbitai]

📝 Walkthrough

Walkthrough

The pull request adds dock badge functionality to the WorkspaceManager to display the count of pending completions. A new updateDockBadge() method is introduced and called at multiple lifecycle points including completion enqueueing, surface activation/closure, workspace loading, and workspace deletion.

Changes

Cohort / File(s)	Summary
Dock Badge Update Implementation Sources/Shellraiser/Services/Workspaces/WorkspaceManager+Completions.swift	Adds updateDockBadge() method that counts pending completions and updates the app's dock badge. Invokes this method after enqueueing a completion and when handling the .started phase of agent activity events.
Dock Badge Update Integration Points Sources/Shellraiser/Services/Workspaces/WorkspaceManager+SurfaceOperations.swift, Sources/Shellraiser/Services/Workspaces/WorkspaceManager+WorkspaceLifecycle.swift	Integrates updateDockBadge() calls after notification cleanup in surface close/activation workflows, and after loading persisted workspaces and deleting workspaces. Adds AppKit import to WorkspaceLifecycle extension.

Possibly related PRs

• Fix pending count capped at 1, show count in sidebar bell #25: Modifies pending completion clearing behavior in enqueueCompletion and agent event handling, which overlaps with where the new dock badge updates are triggered.
• Fix workspace delete confirmation focus #22: Updates the workspace deletion flow in WorkspaceManager+WorkspaceLifecycle.swift, the same file where dock badge updates are now called post-deletion.
• Add workspace busy badge indicator #15: Changes to closeSurface and activateSurface methods in WorkspaceManager that manage surface state and indicators, which now include the dock badge update calls.

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately and concisely summarizes the main change: adding a dock icon badge that displays the count of pending completions, which is the primary objective across all modified files.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch app-icon-notifications

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Tip

CodeRabbit can suggest fixes for GitHub Check annotations.

Configure the reviews.tools.github-checks setting to adjust the time to wait for GitHub Checks to complete.

[coderabbitai]

🧹 Nitpick comments (1)

Sources/Shellraiser/Services/Workspaces/WorkspaceManager+Completions.swift (1)

233-236: Avoid sorting when only pending count is needed.

pendingCompletionTargets() sorts the full queue; for badge count this does extra work. Consider counting directly from pane/workspace pending metadata.

Lightweight count path

     `@MainActor`
     func updateDockBadge() {
-        let count = pendingCompletionTargets().count
+        let count = workspaces.reduce(into: 0) { total, workspace in
+            total += workspace.rootPane.pendingCompletionCount()
+        }
         NSApp.dockTile.badgeLabel = count > 0 ? "\(count)" : nil
     }

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@Sources/Shellraiser/Services/Workspaces/WorkspaceManager`+Completions.swift
around lines 233 - 236, updateDockBadge() calls pendingCompletionTargets(),
which sorts the full queue unnecessarily just to get a count; replace that call
with a lightweight count computed from the workspace/pane pending metadata
(e.g., iterate pane.workspaces or pane.pendingCompletionFlags) instead of
sorting. Modify updateDockBadge() to compute the integer count directly from the
pending state source used by pendingCompletionTargets() and only call
pendingCompletionTargets() (or perform sorting) where the full sorted list is
actually required.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@Sources/Shellraiser/Services/Workspaces/WorkspaceManager`+Completions.swift:
- Around line 233-236: updateDockBadge() calls pendingCompletionTargets(), which
sorts the full queue unnecessarily just to get a count; replace that call with a
lightweight count computed from the workspace/pane pending metadata (e.g.,
iterate pane.workspaces or pane.pendingCompletionFlags) instead of sorting.
Modify updateDockBadge() to compute the integer count directly from the pending
state source used by pendingCompletionTargets() and only call
pendingCompletionTargets() (or perform sorting) where the full sorted list is
actually required.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 6a758717-3622-434e-9636-a539648e859d

📥 Commits

Reviewing files that changed from the base of the PR and between 9d13df9 and 0548369.

📒 Files selected for processing (3)

• Sources/Shellraiser/Services/Workspaces/WorkspaceManager+Completions.swift
• Sources/Shellraiser/Services/Workspaces/WorkspaceManager+SurfaceOperations.swift
• Sources/Shellraiser/Services/Workspaces/WorkspaceManager+WorkspaceLifecycle.swift