Skip to content

Lewis/lp gate #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carhartlewis merged 2 commits into from
Aug 4, 2026
+17 −6
Merged

Lewis/lp gate #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8871e49
fix(proxy): update redirect logic for signed-out users
carhartlewis Aug 4, 2026
73875f0
fix(proxy): refine redirect logic for sign-in path
carhartlewis Aug 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions apps/app/proxy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@ const LANDING_PATH = "/";

const SIGN_IN_PATH = "/sign-in";

const PUBLIC = [SIGN_IN_PATH];

const UNGATED = [SIGN_IN_PATH, "/grant-access", "/eve"];
const UNGATED = ["/grant-access", "/eve"];

const SECTIONS = ["/companies", "/contacts", "/deals", "/settings"];

export async function proxy(request: NextRequest) {
const { pathname } = request.nextUrl;

if (pathname === SIGN_IN_PATH) return NextResponse.next();

if (
getSessionCookie(request, { cookiePrefix: AUTH_COOKIE_PREFIX }) === null
) {
Expand Down Expand Up @@ -71,9 +71,7 @@ function isUnder(pathname: string, prefix: string): boolean {
}

function isPublic(pathname: string): boolean {
if (pathname === LANDING_PATH) return isMarketing();

return PUBLIC.some((prefix) => isUnder(pathname, prefix));
return pathname === LANDING_PATH && isMarketing();
}

function isUngated(pathname: string): boolean {
Expand Down
13 changes: 13 additions & 0 deletions apps/app/test/onboarding-gate.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,19 @@ describe("proxy", () => {
expect(redirectedTo(await proxy(request("/sign-in")))).toBeNull();
});

it("never aims a redirect at the sign-in page itself", async () => {
marketing(undefined);
setup({ onboarded: false, configured: false });

expect(redirectedTo(await proxy(request("/sign-in")))).toBeNull();
expect(
redirectedTo(await proxy(request("/sign-in", [SESSION_COOKIE]))),
).toBeNull();
expect(
redirectedTo(await proxy(request("/sign-in?method=google"))),
).toBeNull();
});

it("reads the flag on every request, and only the literal true turns it on", async () => {
marketing("false");
expect(redirectedTo(await proxy(request("/")))).toBe("/sign-in");
Expand Down