Skip to content

Conversation

@cmillar-trunk
Copy link
Collaborator

@cmillar-trunk cmillar-trunk commented Jan 7, 2026

We've had customers skip past the log noting that we couldn't get quarantine status and log errors about not understanding why the tests were not quarantined. Emboldening that text as a quick modifier.

Before:
Screenshot from 2026-01-07 10-03-01

After:
Screenshot from 2026-01-07 10-21-20

We've had customers skip past the log noting that we couldn't get
quarantine status and log errors about not understanding why the tests
were not quarantined. Emboldening that text as a quick modifier.
@trunk-io
Copy link

trunk-io bot commented Jan 7, 2026

😎 Merged successfully - details.

Copy link

@acatxnamedvirtue acatxnamedvirtue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is better than the Dim, but I wonder if we should change the text color overall, maybe Yellow for Warning? Red/Error probably not appropriate here

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.08%. Comparing base (e041f5c) to head (9f42b61).

Files with missing lines Patch % Lines
cli/src/upload_command.rs 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #972      +/-   ##
==========================================
+ Coverage   80.81%   81.08%   +0.27%     
==========================================
  Files          66       66              
  Lines       14100    14101       +1     
==========================================
+ Hits        11395    11434      +39     
+ Misses       2705     2667      -38     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmillar-trunk
Copy link
Collaborator Author

I think this is better than the Dim, but I wonder if we should change the text color overall, maybe Yellow for Warning? Red/Error probably not appropriate here

Good point, updating to yellow.

@trunk-io trunk-io bot merged commit 2b6fc4f into main Jan 7, 2026
25 checks passed
@trunk-staging-io
Copy link

trunk-staging-io bot commented Jan 7, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

@trunk-io
Copy link

trunk-io bot commented Jan 7, 2026

Static BadgeStatic BadgeStatic BadgeStatic Badge

View Full Report ↗︎Docs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants