-
Notifications
You must be signed in to change notification settings - Fork 5
Embolden unable to get quarantine status #972
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Embolden unable to get quarantine status #972
Conversation
We've had customers skip past the log noting that we couldn't get quarantine status and log errors about not understanding why the tests were not quarantined. Emboldening that text as a quick modifier.
|
😎 Merged successfully - details. |
acatxnamedvirtue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is better than the Dim, but I wonder if we should change the text color overall, maybe Yellow for Warning? Red/Error probably not appropriate here
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #972 +/- ##
==========================================
+ Coverage 80.81% 81.08% +0.27%
==========================================
Files 66 66
Lines 14100 14101 +1
==========================================
+ Hits 11395 11434 +39
+ Misses 2705 2667 -38 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Good point, updating to yellow. |
We've had customers skip past the log noting that we couldn't get quarantine status and log errors about not understanding why the tests were not quarantined. Emboldening that text as a quick modifier.
Before:

After:
