Fix: LineBreak within optional chaining#335
Closed
AndreasHoffmann2 wants to merge 3 commits into
Closed
Conversation
Owner
|
Looks right, will merge asap |
Author
|
Thank you! |
Author
|
Since we hit another very similar issue, I created a unit-test for this. And the fix above does not fix the issue. |
Author
|
We created a unit test and did now really fix the issue. |
Owner
|
Looks good, will merge asap |
Author
|
We found several other issues with the line-breaks and are currently working on a generic test and the necessary fixes. Please do not merge this one for the moment. |
Author
|
Closed since we have a better test now. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We got an error from the minified code in the browser:
The linebreak between "?" and "." should not be there.
The code attached should do the trick I guess.