Fix/spaces primitive atoms - #217
Open
NatnaelTigistu wants to merge 3 commits into
Open
NatnaelTigistu wants to merge 3 commits into
NatnaelTigistu wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
add-atomdropping primitive values. Previously,spaces.plstrictly expected incoming atoms to be S-Expression lists ([Rel|Args]). Adding a scalar primitive (like42or"Hello") would silently fail unification and be dropped. This PR wraps non-list atoms using an internal#primitivemarker when asserting them to the Prolog database, and unwraps them duringget-atomsandmatchoperations..gitignore. Replaced the specific__pycache__directory rules with a global__pycache__/rule, and ignored the dynamically generatedrepos/folder to keep untracked files clean.Changes
src/spaces.pl: Added list-checking inadd_sexp,remove_sexp, andmatch, ensuring primitives are safely stored and queried..gitignore: Globalized__pycache__and addedrepos/.examples/test_add_primitive.mettato the automated test suite to prevent regressions.Testing
42,"Hello",true) are now successfully added and returned from!(match &space $x $x).sh test.shcontinue to pass without regressions.