Overhaul import loading semantics - #201
Closed
rTreutlein wants to merge 5 commits into
Closed
rTreutlein wants to merge 5 commits into
rTreutlein wants to merge 5 commits into
Conversation
Collaborator
Author
|
Signature prescanning is causing more trouble than it's worth so i will be removing it and creating a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Overhaul file imports by combining the strongest parts of the existing import PRs into one coherent loader:
loadingandloadedstates;existence_error(source_sink, ...)for missing files;git-import!fromlib_importinto the core loader;The signature prescan remains separate from normal module execution, so imported atoms, clauses, and top-level runnables are still processed normally.
git-import!is the one core dependency primitive prepared before that scan because it can make later imports resolvable.This consolidates ideas explored in #157, #159, #161, #171, #189, and #195. It addresses #154, #180, #181, and #196.
Validation