Repository navigation
feat: add youcom (You.com) provider to WebSearchTool #358
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
valueadd-lgtm
wants to merge
7
commits into
trpc-group:main
Choose a base branch
from
valueadd-lgtm:feat/youcom-search-integration
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
ed846d4
feat: add youcom (You.com) provider to WebSearchTool
valueadd-lgtm 04c3ea9
fix: harden youcom SSE parsing and payload handling
valueadd-lgtm 5874601
Address review: isolate You.com request headers, honor snippets field…
valueadd-lgtm b5515a2
fix: suppress client-level auth and cookie leakage in the You.com SSE…
valueadd-lgtm dc9f1f9
Address review: tighten SSE transport hardening for the You.com call
valueadd-lgtm b7cc7ae
Address review: per-hop redirect validation, jar rollback, typed hit …
valueadd-lgtm 62a652c
Address review: separator-first SSE frame join, value-aware cookie ro…
valueadd-lgtm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问题: 本行把
provider返回值表更新为包含youcom,但紧随其后的summary字段行未同步:zh 文档已加入"You.com 在 JSON-RPC / 工具错误时也会把错误信息写入此字段",en 文档仍只写 DDG/Google/Tavily,中英文档对新行为的描述不一致。触发条件: 阅读英文文档的用户按需依赖 summary 作为错误通道时无此信息。
实际影响: 文档误导——en 用户会以为 youcom 从不往 summary 写错误信息,错误处理与引用逻辑按文档假设实现时行为偏差。
修正方向: 将 zh 对应的 summary 行说明同步到
docs/mkdocs/en/tool.md("You.com 在 JSON-RPC / 工具错误时也会把错误信息写入 summary")。