Repository navigation
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Browser request saturation previously dropped ordinary requests without a reply, while revocations could bypass the active-work limit. This change returns explicit overload failures, caps sender waiters and desktop active work at 256 ordinary requests plus 16 reserved revocation slots, and preserves cancellation and native-settlement accounting.
Request envelopes now have a 128 KiB UTF-8 JSON budget. Sender admission checks before transmission; desktop validates the full inner envelope (including unused fields) before parsing and closes the channel on invalid/oversized input. Duplicate IDs preserve the original response waiter. The budget accommodates existing escaped text and site-tool inputs. Outer SSE/RPC allocations and response budgets are unchanged; this is not a process-wide memory guarantee.
Documents the #83 trust decision: the authenticated shared OpenCode backend is trusted to identify sessions, while desktop retains browser grant enforcement. Isolation after backend compromise is outside this guarantee. No per-task credentials or worker isolation are added. Verified that normal CookieMonster startup uses the server's localhost default and requires authentication; no binding changes were needed.
Closes #83. Base:
v2-upgrade.Validation
bun run checkpassed.lint:changed origin/v2-upgraderemains blocked by 10 pre-existing bridge warnings (unknown IPC boundaries and conditional spreads). Verified those same warnings on the base branch; no suppressions or unrelated cleanup added. A separate lint cleanup would be needed for that stricter check.