Skip to content

fix(ci): enable signed macOS builds and repair fork checks - #71

Closed
trmosala wants to merge 11 commits into
devfrom
macos-signing
Closed

trmosala wants to merge 11 commits into
devfrom
macos-signing

Conversation

@trmosala

@trmosala trmosala commented Oct 17, 2026 •

Copy link
Copy Markdown
Owner

CookieMonster macOS builds currently force unsigned packaging. Enable Developer ID signing and Apple notarization using the Apple Actions secrets, then verify the app signature, Gatekeeper assessment, and stapled app ticket before uploading the installer. Packaging rejects missing signing/notarization credentials and removes the temporary API key even on failure. The separate DMG contains the notarized app; it does not receive a separate notarization ticket.

Required fork checks were indefinitely queued for unregistered Blacksmith runners. Typecheck, Nix evaluation, and Linux/Windows unit and e2e checks now use GitHub-hosted runners for forks; upstream retains its Blacksmith runners.

Running those checks exposed existing baseline failures. Restore the established native-key order, convert the four broken positional menu dictionaries into keyed translations, and include untranslated fork copy in the existing shared English fallback. All English keys and strings are preserved. Normalize the Nastaliq script variant to Arabic for locale matching, and update the stale public event-count assertion to 89.

Browser fixtures now explicitly select their intended UI, share the configured mock-server address, and exercise current panel and command-palette flows. Install Chromium for browser-backed unit tests, refresh the task-tool parameter snapshot, and cover the eight previously unexercised API routes. Give core filesystem/process integration tests the same 30-second limit as the backend suite so Windows can finish first-use ripgrep extraction and Git snapshot operations. Fork runners execute one package test task at a time to avoid browser-build/CLI-startup contention. Review fixtures initialize their intended per-session tabs, screenshot tests wait for their own viewport acknowledgement, loader tests set Chromium’s OS motion preference and poll for a rendered animation frame, and full CLI subprocess tests run sequentially to avoid startup contention on hosted runners. Keep CM3 recent and pinned rows keyed by session ID so live refreshes preserve keyboard focus. The timeline visibility probe still rejects missing or collapsed content while allowing bottom-follow scrolling when the interruption label adds height.

Review hover coverage polls immediate gutter state before focusing and activating the Comment control once, avoiding a nested assertion that consumes the entire retry window. Declaration emission runs the installed TypeScript compiler with Node, bypassing the Windows bunx path that exited with code 66 and no compiler diagnostics.

Validation:

  • All five review-line-comment cases and six CPU-throttled hover-invalidation runs pass. The original retry fails the invalidation probe and the revised flow passes. The changed case is included in E2E typechecking.
  • HTTP recorder build and packaged-consumer verification pass. A Bun 1.4.2 launcher-boundary probe reproduces the empty exit-66 error with the old build and succeeds with the revised build. This fault injection is not a native Windows reproduction; Windows confirmation remains in CI.
  • Signed macOS packaging and installer smoke test passed; publishing was disabled and the validated DMG is available as an artifact.
  • 23 localization tests and two event-manifest tests pass locally, including regressions for all four menu mappings and explicit Nastaliq locale matching.
  • All 1,107 core tests, 837 app unit tests, 76 browser-backed unit tests, 58 tool-parameter tests with 16 snapshots, and the mock file-search regression pass locally.
  • Focused browser checks pass for keyboard navigation, both prompt layouts and directions, timeline completion/interruption, landing suggestions, command-palette archiving, and panel retention in both directions. Review image rendering, tab identity, state persistence, terminal geometry, and legacy panel retention pass focused local checks.
  • All 13 CLI subprocess tests pass sequentially with their existing time limits. The broader local backend run passed 3,720 tests and failed one SDK case; all 18 SDK cases then passed together in isolation. A second backend run under serial Turbo scheduling passed 3,720 tests and failed one shell-output case, which passed in isolation; it had no CLI startup failures. Both backend snapshot tests that timed out under concurrent local load also pass in isolation.
  • Production sidebar navigation benchmarks pass before and after the focus fix (stable navigation: 615 ms baseline, 175 ms changed; individual diagnostic runs, no hardware-dependent threshold).
  • Generated-client verification passes; HttpApi coverage and authorization each pass all 216 scenarios. Full API execution also passes all 216 scenarios. Final cross-platform CI results are pending.
  • App and E2E typechecks pass; affected-file lint reports no errors.
  • actionlint passes for all changed workflows; the credential-setup self-check covers missing values, exact key-file contents, and mode 0600.
  • bun run check is unavailable on this base (no check script); the repository's full typecheck also runs in the pre-push hook.

Unicode reference for script normalization: Nastaliq uses the Arabic character repertoire.

@github-actions

Copy link
Copy Markdown
Contributor

This PR doesn't fully meet our contributing guidelines and PR template.

What needs to be fixed:

  • PR description is missing required template sections. Please use the PR template.

Please edit this PR description to address the above within 2 hours, or it will be automatically closed.

If you believe this was flagged incorrectly, please let a maintainer know.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your contribution!

This PR doesn't have a linked issue. All PRs must reference an existing issue.

Please:

  1. Open an issue describing the bug/feature (if one doesn't exist)
  2. Add Fixes #<number> or Closes #<number> to this PR description

See CONTRIBUTING.md for details.

@trmosala
trmosala marked this pull request as ready for review October 17, 2026 10:34
@trmosala trmosala changed the title fix(desktop): sign and notarize macOS builds fix(ci): enable signed macOS builds and repair fork checks Oct 17, 2026
Poll immediate gutter hover state so a nested assertion cannot exhaust the retry budget, then activate the focused Comment control once. Include the case in E2E typechecking.

Invoke the installed TypeScript compiler with Node for declaration emission, bypassing the bunx launcher that exited without diagnostics on Windows. Validate package consumers and the launcher-failure boundary locally; native Windows confirmation remains in CI.
@trmosala trmosala closed this Oct 19, 2026
@trmosala
trmosala deleted the macos-signing branch October 19, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant