Repository navigation
Conversation
Contributor
|
This PR doesn't fully meet our contributing guidelines and PR template. What needs to be fixed:
Please edit this PR description to address the above within 2 hours, or it will be automatically closed. If you believe this was flagged incorrectly, please let a maintainer know. |
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
trmosala
marked this pull request as ready for review
October 17, 2026 10:34
added 5 commits
October 17, 2026 14:53
Poll immediate gutter hover state so a nested assertion cannot exhaust the retry budget, then activate the focused Comment control once. Include the case in E2E typechecking. Invoke the installed TypeScript compiler with Node for declaration emission, bypassing the bunx launcher that exited without diagnostics on Windows. Validate package consumers and the launcher-failure boundary locally; native Windows confirmation remains in CI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CookieMonster macOS builds currently force unsigned packaging. Enable Developer ID signing and Apple notarization using the Apple Actions secrets, then verify the app signature, Gatekeeper assessment, and stapled app ticket before uploading the installer. Packaging rejects missing signing/notarization credentials and removes the temporary API key even on failure. The separate DMG contains the notarized app; it does not receive a separate notarization ticket.
Required fork checks were indefinitely queued for unregistered Blacksmith runners. Typecheck, Nix evaluation, and Linux/Windows unit and e2e checks now use GitHub-hosted runners for forks; upstream retains its Blacksmith runners.
Running those checks exposed existing baseline failures. Restore the established native-key order, convert the four broken positional menu dictionaries into keyed translations, and include untranslated fork copy in the existing shared English fallback. All English keys and strings are preserved. Normalize the Nastaliq script variant to Arabic for locale matching, and update the stale public event-count assertion to 89.
Browser fixtures now explicitly select their intended UI, share the configured mock-server address, and exercise current panel and command-palette flows. Install Chromium for browser-backed unit tests, refresh the task-tool parameter snapshot, and cover the eight previously unexercised API routes. Give core filesystem/process integration tests the same 30-second limit as the backend suite so Windows can finish first-use ripgrep extraction and Git snapshot operations. Fork runners execute one package test task at a time to avoid browser-build/CLI-startup contention. Review fixtures initialize their intended per-session tabs, screenshot tests wait for their own viewport acknowledgement, loader tests set Chromium’s OS motion preference and poll for a rendered animation frame, and full CLI subprocess tests run sequentially to avoid startup contention on hosted runners. Keep CM3 recent and pinned rows keyed by session ID so live refreshes preserve keyboard focus. The timeline visibility probe still rejects missing or collapsed content while allowing bottom-follow scrolling when the interruption label adds height.
Review hover coverage polls immediate gutter state before focusing and activating the Comment control once, avoiding a nested assertion that consumes the entire retry window. Declaration emission runs the installed TypeScript compiler with Node, bypassing the Windows
bunxpath that exited with code 66 and no compiler diagnostics.Validation:
bun run checkis unavailable on this base (nocheckscript); the repository's full typecheck also runs in the pre-push hook.Unicode reference for script normalization: Nastaliq uses the Arabic character repertoire.