Skip to content

fix(desktop): unblock the Windows release workflow after the V2 packaging changes - #106

Merged
trmosala merged 1 commit into
devfrom
windows-release-build
Nov 8, 2026
Merged

trmosala merged 1 commit into
devfrom
windows-release-build

Conversation

@trmosala

@trmosala trmosala commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Issue for this PR

No separate issue: the cookiemonster-windows run for v2.2.5_01 failed before packaging (https://github.com/trmosala/opencode/actions/runs/42501769031).

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

The Windows release workflow had been broken since #100. Its "Test Windows packaging" step imports the AE adapter that cm-v2 builds, but that step ran before anything built cm-v2, so all 12 packaging tests failed with Cannot find module '@cookiemonster/cm-v2/ae-plugin'. The step now builds cm-v2 first.

Two pre-V2 expectations are updated to match what packaging actually ships:

  • AE bundle: it now includes server.js and package.json.
  • CM Browser: it ships as cm-browser/dist/plugin-v2.mjs. This is checked both in electron-builder.config.test.ts and in the workflow's post-package check.

How did you verify your code works?

  • Packaging tests: run with the workflow's own settings (CM_BRAND=0 CM_UNSIGNED=0 OPENCODE_CHANNEL=dev bun test electron-builder.config.test.ts src/main/system-cli.test.ts), all 16 pass. Before the change, the AE test failed on its file list.
  • Workflow file: it parses as valid YAML.
  • Real Windows run: the run triggered by the v2.2.5_02 release, after merge, is the real check.

Screenshots / recordings

Not a UI change.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

Created with Claude Opus 5.5 in Claude Code.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BGEckNXWHdeBNN9ZKCc8ma

…ging changes

The cookiemonster-windows run for v2.2.5_01 failed before packaging. Its
packaging tests import the AE adapter that cm-v2 builds, which does not exist
yet at that step. The workflow now builds cm-v2 first. The packaging test and
the post-package check also expected pre-V2 layouts. They now match what
packaging ships: the AE bundle includes server.js and package.json, and CM
Browser ships as cm-browser/dist/plugin-v2.mjs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BGEckNXWHdeBNN9ZKCc8ma
@trmosala
trmosala merged commit 981d11d into dev Nov 8, 2026
@trmosala
trmosala deleted the windows-release-build branch November 8, 2026 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant