Repository navigation
fix(desktop): unblock the Windows release workflow after the V2 packaging changes - #106
Merged
Merged
Conversation
…ging changes The cookiemonster-windows run for v2.2.5_01 failed before packaging. Its packaging tests import the AE adapter that cm-v2 builds, which does not exist yet at that step. The workflow now builds cm-v2 first. The packaging test and the post-package check also expected pre-V2 layouts. They now match what packaging ships: the AE bundle includes server.js and package.json, and CM Browser ships as cm-browser/dist/plugin-v2.mjs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BGEckNXWHdeBNN9ZKCc8ma
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
No separate issue: the cookiemonster-windows run for v2.2.5_01 failed before packaging (https://github.com/trmosala/opencode/actions/runs/42501769031).
Type of change
What does this PR do?
The Windows release workflow had been broken since #100. Its "Test Windows packaging" step imports the AE adapter that
cm-v2builds, but that step ran before anything builtcm-v2, so all 12 packaging tests failed withCannot find module '@cookiemonster/cm-v2/ae-plugin'. The step now buildscm-v2first.Two pre-V2 expectations are updated to match what packaging actually ships:
server.jsandpackage.json.cm-browser/dist/plugin-v2.mjs. This is checked both inelectron-builder.config.test.tsand in the workflow's post-package check.How did you verify your code works?
CM_BRAND=0 CM_UNSIGNED=0 OPENCODE_CHANNEL=dev bun test electron-builder.config.test.ts src/main/system-cli.test.ts), all 16 pass. Before the change, the AE test failed on its file list.Screenshots / recordings
Not a UI change.
Checklist
Created with Claude Opus 5.5 in Claude Code.
🤖 Generated with Claude Code
https://claude.ai/code/session_01BGEckNXWHdeBNN9ZKCc8ma