Skip to content

feat(browser): broaden automatic login-save compatibility #9

Closed

Description

@trmosala

Problem

Offers currently require trusted same-origin POST form submissions and disappearance of the login form.

Implementation order

Browser backlog item 05 of 29. Phase: Passwords and autofill. This is ordered planning, not a claim that Codex implements every item. Items 24–29 are optional additions.

Acceptance criteria

  • Support selected formless JavaScript and persistent-form login patterns.
  • Retain explicit confirmation and honest heuristic wording; avoid weakening origin/visibility checks.
  • Add fixtures for success, rejection, repeated submissions and multistep flows.

Dependencies

Engineering and validation

Reuse existing Chromium/Electron/OS facilities where available. Preserve main-process ownership and permission enforcement, add no placeholder controls, use existing i18n patterns, and test behavior with synthetic fixtures. Document platform limitations. Baseline: browser-tabs at 47fef3e; see packages/cm-browser/README.md and password-security.md.

Activity

  1. trmosala commented on Sep 16, 2026

    @trmosala
    OwnerAuthor

    Published in e366d28 (feat(browser): support selected login-save patterns). Normal push completed with hooks enabled; git ls-remote origin refs/heads/browser-tabs matches HEAD. Exactly five scoped files committed.

    Supported scope:

    • Persistent native login: a scoped trusted exact-origin POST submission followed by script clearing the original still-visible, usable password field. Form/account/control identity and effective destinations are revalidated.
    • Selected native-backed formless login: trusted unmodified Enter on explicit visible username/current-password fields, same-turn association of those same fields with an exact-origin POST form, then requestSubmit() before gesture expiry.
    • NO general fetch/XHR-only login detection, arbitrary click capture, or formless registration/change support.

    Explicit default-cancel native confirmation and honest sign-in-success wording remain. Success is a heuristic, not authentication proof. Capture, exact-origin, visibility, private-tab and vault rules remain; no new plaintext cache or page-visible vault API.

    Verification after the final rejection-acknowledgement race fix:

    • bun scripts/browser-smoke.ts --offer-patterns, --offers, --registration, --generation: PASS.
    • bun test src/main/browser: 31 passed, 0 failed.
    • Desktop bun typecheck: PASS.
    • Parent reports full bun scripts/browser-smoke.ts: PASS after the final fix.
    • Reviewer ses_f5905c6a3ffeYlhAvgmZBvPSmg: complete scoped feat(browser): broaden automatic login-save compatibility #9 review against c148c22, no actionable findings. Source-only, not external assurance.
    • Scoped formatting and staged whitespace checks: PASS; LF/CRLF notices only.
    • Root scoped oxlint on four owned TS files: 46 warnings, 0 errors, including existing/new warnings; not warning-free.
    • Normal pre-push hook: 31/31 typecheck tasks successful (29 cached). Completed feature tests were not rerun during evidence-only publication.

    Test-first regressions cover delayed cleanup versus immediate trusted-input resubmission, hash/history snapshot retention and effective destinations, and held negative acknowledgement across routing/signal removal. Already-observed rejection now revokes the still-owned candidate/context; stale positives, newer submissions and cross-document handoffs retain their guards. The fixture budget is 120 seconds; the earlier 60-second timeout and initial-click failure during a concurrent run are documented. Subsequent standalone runs passed; registration emitted a Mojo diagnostic but passed.

    Keeping #9 OPEN: native dialogs/authentication are stubbed in isolated Windows Chromium fixtures. Real native usability/accessibility/authentication, macOS/packaged-build validation and #34 external assurance remain outstanding. No release or installed-process restart. #10 has not started.

  2. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    MacOS verification evidence committed and pushed to browser-tabs in 9d3cafc (docs(browser): record login-save macOS validation gaps). Existing selected-pattern implementation remains e366d28; no production or fixture changes were retained.

    PASS on macOS arm64 / Electron 44.3.0 / Bun 1.3.14: desktop typecheck, 257 browser unit tests with 3,087 expectations, and separate --offer-patterns, --offers and --generation native fixtures. Scoped source audit found no actionable gaps in the selected persistent-form and native-backed formless paths. Formatting and whitespace checks passed; normal pre-push hook passed 31/31 typecheck tasks.

    Leaving this issue OPEN rather than claiming all validation passed:

    • Registration was inconsistent. Diagnostic runs observed native window hide followed by the correct vault lock and null capture. The hide trigger remains unknown. A separate navigation-during-dialog timeout remains unexplained. One instrumented pass does not establish stability.
    • Default browser smoke failed separately in snapshotsSmoke: text replacement produced safe/safe/olsafe instead of safe/safe/safe. Cause not established.
    • All temporary diagnostics were removed. No security guards were bypassed.

    Registration investigation needs a controlled desktop run without unexpected hide/minimize/session changes, or a reproducible native-hide trigger. Full details are in packages/cm-browser/password-security.md under the dated macOS follow-up. Physical/platform acceptance remains under #19 and password-manager release assurance under #34; these synthetic fixtures do not verify actual Touch ID/Keychain, packaged builds or external security assurance.

  3. trmosala commented on Sep 21, 2026

    @trmosala
    OwnerAuthor

    Closing as implemented with the user accepting the documented scope and remaining validation work. This supersedes the earlier recommendation to keep #9 open.

    The selected persistent-form and native-backed formless login-save paths are implemented in e366d28. Explicit default-cancel confirmation, honest heuristic wording, origin/visibility checks, and success/rejection/repeated-submission/multistep fixtures remain intact. Focused --offer-patterns and --offers checks passed on macOS; verification evidence was committed and pushed in 9d3cafc.

    This closure does not claim general fetch/XHR-only login support, a clean full smoke suite, or release assurance. The registration native-hide/vault-lock failures, unexplained navigation timeout, and separate text-replacement failure remain documented in the preceding comment and password-security.md. They were not established as defects in the selected #9 paths and are accepted as follow-up validation work, not erased or reported as passing.

    Physical/platform acceptance remains under #19; authentication, packaged-build and external security assurance remain under #34. No security guards were weakened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions